Bug 195147 - [patch] comms/gammu: Add mysql support
Summary: [patch] comms/gammu: Add mysql support
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-18 14:55 UTC by Lukasz Wasikowski
Modified: 2016-10-13 19:05 UTC (History)
1 user (show)

See Also:
lukasz: maintainer-feedback? (bsam)


Attachments
gammu mysql patch (552 bytes, patch)
2014-11-18 14:55 UTC, Lukasz Wasikowski
no flags Details | Diff
Revised gammu mysql patch (6.60 KB, patch)
2015-09-22 10:45 UTC, Lukasz Wasikowski
no flags Details | Diff
portlint -C output (1.05 KB, text/x-log)
2015-09-22 10:46 UTC, Lukasz Wasikowski
no flags Details
poudriere testport with all options off (676.19 KB, text/x-log)
2015-09-22 10:47 UTC, Lukasz Wasikowski
no flags Details
poudriere testport with all options on (692.67 KB, text/x-log)
2015-09-22 10:47 UTC, Lukasz Wasikowski
no flags Details
gammu mysql patch (9.30 KB, patch)
2015-09-29 12:16 UTC, Lukasz Wasikowski
no flags Details | Diff
portlint -C output (1.05 KB, text/x-log)
2015-09-29 12:19 UTC, Lukasz Wasikowski
no flags Details
poudriere testport with all options off (692.99 KB, text/x-log)
2015-09-29 12:20 UTC, Lukasz Wasikowski
no flags Details
poudriere testport with all options on (690.82 KB, text/x-log)
2015-09-29 12:20 UTC, Lukasz Wasikowski
no flags Details
poudriere testport with bash on, mysql off (677.29 KB, text/x-log)
2015-09-29 12:21 UTC, Lukasz Wasikowski
no flags Details
poudriere testport with bash off, mysql on (692.41 KB, text/x-log)
2015-09-29 12:22 UTC, Lukasz Wasikowski
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lukasz Wasikowski 2014-11-18 14:55:46 UTC
Created attachment 149559 [details]
gammu mysql patch

Gammu detects MySQL presence at configure time. If you build gammu with poudriere or on a system with no MySQL installed gammu won't have MySQL support. This simple patch resolved that issue for me.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-11-18 14:55:46 UTC
Auto-assigned to maintainer bsam@FreeBSD.org
Comment 2 Lukasz Wasikowski 2015-09-19 10:07:55 UTC
I'd call maintainer timeout on this.
Comment 3 Lukasz Wasikowski 2015-09-22 10:45:02 UTC
Created attachment 161266 [details]
Revised gammu mysql patch

Add MySQL support to gammu. New patch to apply on current ports tree, including `make makepatch` gammu patches to make portlint happy.
Comment 4 Lukasz Wasikowski 2015-09-22 10:46:03 UTC
Created attachment 161267 [details]
portlint -C output
Comment 5 Lukasz Wasikowski 2015-09-22 10:47:04 UTC
Created attachment 161268 [details]
poudriere testport with all options off
Comment 6 Lukasz Wasikowski 2015-09-22 10:47:20 UTC
Created attachment 161269 [details]
poudriere testport with all options on
Comment 7 Kurt Jaeger freebsd_committer freebsd_triage 2015-09-22 20:27:26 UTC
Close, but it fails if BASH is off and MYSQL is on, in

make check-plist

with

===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: etc/bash_completion.d/gammu
Comment 8 Lukasz Wasikowski 2015-09-29 12:16:51 UTC
Created attachment 161524 [details]
gammu mysql patch
Comment 9 Lukasz Wasikowski 2015-09-29 12:19:29 UTC
Created attachment 161525 [details]
portlint -C output
Comment 10 Lukasz Wasikowski 2015-09-29 12:20:15 UTC
Created attachment 161526 [details]
poudriere testport with all options off
Comment 11 Lukasz Wasikowski 2015-09-29 12:20:59 UTC
Created attachment 161527 [details]
poudriere testport with all options on
Comment 12 Lukasz Wasikowski 2015-09-29 12:21:52 UTC
Created attachment 161528 [details]
poudriere testport with bash on, mysql off
Comment 13 Lukasz Wasikowski 2015-09-29 12:22:43 UTC
Created attachment 161529 [details]
poudriere testport with bash off, mysql on
Comment 14 Lukasz Wasikowski 2015-09-29 12:26:25 UTC
(In reply to Kurt Jaeger from comment #7)

Should be better now.

---Begin OPTIONS List---
===> The following configuration options are available for gammu-1.33.0_1:
     BASH=off: Install programmable completions for Bash
     MYSQL=on: MySQL database support
===> Use 'make config' to modify these settings
---End OPTIONS List---

====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
===> No pkg-plist issues found (check-plist)
Comment 15 Boris Samorodov freebsd_committer freebsd_triage 2016-10-13 18:59:04 UTC
Back to the pool.
Comment 16 Lukasz Wasikowski 2016-10-13 19:05:44 UTC
Current comms/gammu in ports got MySQL support during version bump.