Bug 195224 - Update of audio/firefly
Summary: Update of audio/firefly
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Many People
Assignee: Antoine Brodin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-20 16:34 UTC by mr-spott
Modified: 2014-11-23 18:37 UTC (History)
0 users

See Also:

Attachments
firefly-1696_11.diff (8.33 KB, patch)
2014-11-20 16:34 UTC, mr-spott 		no flags Details | Diff
firefly-1696_11.diff (8.47 KB, patch)
2014-11-20 16:56 UTC, mr-spott 		mr-spott: maintainer-approval+
Details | Diff
firefly-1696_11.diff (8.47 KB, patch)
2014-11-20 17:14 UTC, mr-spott 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mr-spott 2014-11-20 16:34:28 UTC 
Created attachment 149644 [details]
firefly-1696_11.diff

Hi,

The other day I became port maintainer of audio/firefly. This is my first update of audio/firefly. Please apply it so people can use it again, since it is currently still marked as broken due to outdated upstream links.

After my update I did this:

root@Storage-03 [/tmp/Maintenance/firefly]$ svn status
M       Makefile
M       files/mt-daapd.in
A       files/pkg-install.in
A       files/pkg-message.in
M       pkg-descr
M       pkg-plist
root@Storage-03 [/tmp/Maintenance/firefly]$ svn update
Aktualisiere ».«:
Revision 372949.
root@Storage-03 [/tmp/Maintenance/firefly]$ svn diff > ../$(make -VPKGNAME).diff

The unified "firefly-1696_11.diff" of the changes is attached to this PR Ticket.

Also, since this is my first commit - pelase let me know where to do better for future commits.

Thank you very much.

Best Regards,
Leander
Comment 1 mr-spott 2014-11-20 16:56:29 UTC 
Created attachment 149645 [details]
firefly-1696_11.diff


... Little ${CHOWN} update in the Makefile ...

Please use this diff, since its the latest

Thanks
Comment 2 mr-spott 2014-11-20 17:14:13 UTC 
Created attachment 149646 [details]
firefly-1696_11.diff

UPDATE:

CHANGED IN
pkg-plist

FROM
@sample etc/firefly/mt-daapd.conf.sample

TO
@sample %%ETCDIR%%/mt-daapd.conf.sample
Comment 3 Antoine Brodin freebsd_committer freebsd_triage 2014-11-23 13:51:43 UTC 
Hi, chown in the makefile doesn't work as a regular user,  that's bad!
Comment 4 Antoine Brodin freebsd_committer freebsd_triage 2014-11-23 14:01:04 UTC 
Take it
Comment 5 commit-hook freebsd_committer freebsd_triage 2014-11-23 15:31:31 UTC 
A commit references this bug:

Author: antoine
Date: Sun Nov 23 15:30:31 UTC 2014
New revision: 373158
URL: https://svnweb.freebsd.org/changeset/ports/373158

Log:
  - Unbreak, by making fetchable again
  - Move dbdir to respect hier(7)
  - Add a pkg-message

  PR:		ports/195224
  Submitted by:	maintainer

Changes:
  head/audio/firefly/Makefile
  head/audio/firefly/files/mt-daapd.in
  head/audio/firefly/files/patch-contrib_Makefile.in
  head/audio/firefly/files/patch-mt-daapd.conf.templ
  head/audio/firefly/files/patch-plugins_out-daap.c
  head/audio/firefly/files/pkg-message.in
  head/audio/firefly/pkg-descr
  head/audio/firefly/pkg-plist
Comment 6 Antoine Brodin freebsd_committer freebsd_triage 2014-11-23 15:33:27 UTC 
Patch committed with a bit of cleanup and minus the pkg-install script.
I think it's overkill to change the passwords or directories, i added a phrase in the pkg-message instead.
Comment 7 mr-spott 2014-11-23 18:37:24 UTC 
(In reply to Antoine Brodin from comment #6)
> Patch committed with a bit of cleanup and minus the pkg-install script.
> I think it's overkill to change the passwords or directories, i added a
> phrase in the pkg-message instead.

Thanks for your effort.