Created attachment 149676 [details]
deforaos-libsystem fails to build on armv6 with this error:
cc -I ../include -D WITH_SSL -W -Wall -fPIC -g -O2 -pedantic -c error.c
error.c:49:31: error: passing 'void *' to parameter of incompatible type 'va_list' (aka '__builtin_va_list')
return _error_do(NULL, NULL, NULL);
/usr/include/sys/_null.h:32:14: note: expanded from macro 'NULL'
#define NULL ((void *)0)
This is the same kind of error that was fixed in databases/mysql55-client (see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193841 for details)
build log on arm is available here:
redports is currently down so I can't provide build logs for other arch but it compiles successfully on current/amd64
Confirmed that this now builds for armv6 with this patch.
amd64 build looks good:
armv6 build is now fixed:
Should I just need to approve this patch, or should I generate a full clean port-diff file using it ?
(In reply to olivier from comment #4)
> Should I just need to approve this patch, or should I generate a full clean
> port-diff file using it ?
Up to you. I can just commit this if you are ok with it.
Yes I'm OK with it.
A commit references this bug:
Date: Thu Nov 27 19:18:14 UTC 2014
New revision: 373519
Repair build on arm with a patch to error.c
Differential Revision: https://reviews.freebsd.org/D1217
Submitted by: firstname.lastname@example.org
Reviewed by: email@example.com
Approved by: bapt (mentor)