Bug 195303 - [zfs] large_blocks enabled on pool, recordsize capped at 1M, minor typo in error message when attempting to create dataset with recordsize=2M
Summary: [zfs] large_blocks enabled on pool, recordsize capped at 1M, minor typo in er...
Status: New
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: amd64 Any
: --- Affects Some People
Assignee: freebsd-fs mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-23 11:56 UTC by Trond.Endrestol
Modified: 2015-11-20 23:52 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Trond.Endrestol 2014-11-23 11:56:48 UTC
On a zpool with the large_blocks feature enabled, recordsize is capped at 1M, however when attempting to create a dataset with recordsize=2M, zpool claims 128KB is the max.

# zfs create -o recordsize=256k zroot/tmp/256k
# zfs create -o recordsize=512k zroot/tmp/512k
# zfs create -o recordsize=1m zroot/tmp/1m
# zfs create -o recordsize=2m zroot/tmp/2m
cannot create 'zroot/tmp/2m': volume block size must be power of 2 from 512B to 128KB

The error message should be changed, if possible, to let the max be known to be 1M, at least when the large_blocks feature is enabled on the zpool in question.
Comment 1 Anton Saietskii 2015-11-19 14:24:01 UTC
(In reply to Trond.Endrestol from comment #0)
The situation is more difficult - maximum record size could be changed, see r374637.
So the pseudocode for displaying error message should be like this:
if [large_blocks_enabled == true]
  max_block_size = sysctl(vfs.zfs.max_recordsize)
else
  max_block_size = 128k
error("Block size cannot be greater than %d", max_block_size)
Comment 2 Anton Saietskii 2015-11-19 14:25:12 UTC
(In reply to Anton Sayetsky from comment #1)
Sorry, wrong revision. Correct is r274673
Comment 3 Anton Saietskii 2015-11-20 23:52:11 UTC
BTW, on 10.2-RELEASE-p7:
root@cs0:~# zfs set recordsize=2m ztemp
cannot set property for 'ztemp': 'recordsize' must be power of 2 from 512B to 1024KB
root@cs0:~#

I have no access to any of -CURRENT machines, but I think that problem has been already fixed there too (because of MFC/MFS rule).