Bug 195320 - [MAINTAINER] [PATCH] ports/databases/mariadb55-server: Fix build on 9.x
Summary: [MAINTAINER] [PATCH] ports/databases/mariadb55-server: Fix build on 9.x
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-24 00:36 UTC by never
Modified: 2014-11-25 09:59 UTC (History)
1 user (show)

See Also:


Attachments
No jemalloc (579 bytes, patch)
2014-11-24 00:36 UTC, never
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description never 2014-11-24 00:36:49 UTC
Created attachment 149759 [details]
No jemalloc

After recent "maintainer timeout" update of the MariaDB port there is no longer need to differentiate between bundled (it is no longer bundled) jemalloc and system one.
Comment 1 John Marino freebsd_committer 2014-11-24 19:01:44 UTC
No, there is a reason.  Please use the code from mariadb100-server, e.g. 

.if ${OPSYS} == FreeBSD && ${OSVERSION} >= 1000012
CMAKE_ARGS+=	-DWITH_JEMALLOC="system"
.else
CMAKE_ARGS+=	-DWITH_JEMALLOC="no"
.endif



or at least


.if ${OPSYS} == FreeBSD 
CMAKE_ARGS+=	-DWITH_JEMALLOC="system"
.else
CMAKE_ARGS+=	-DWITH_JEMALLOC="no"
.endif


DragonFly does not have jemalloc.
Comment 2 John Marino freebsd_committer 2014-11-25 09:51:05 UTC
i'll fix this now.
Comment 3 commit-hook freebsd_committer 2014-11-25 09:58:06 UTC
A commit references this bug:

Author: marino
Date: Tue Nov 25 09:57:30 UTC 2014
New revision: 373396
URL: https://svnweb.freebsd.org/changeset/ports/373396

Log:
  databases/mariadb55-server: Fix FreeBSD 8 and 9 (jemallac issue)

  Bring in MariaDB 10's jemalloc logic to fix FreeBSD 8 and 9.
  While here, convert to USES+= execinfo

  PR:		195320
  Reported by:	FreeBSD 9 users
  Submitted by:	maintainer
  Final fix by:	marino

Changes:
  head/databases/mariadb55-server/Makefile
Comment 4 John Marino freebsd_committer 2014-11-25 09:59:12 UTC
That should do the trick and make everyone happy.