Bug 195680 - devel/git: color diff prints instead of evaluating the color sequences
Summary: devel/git: color diff prints instead of evaluating the color sequences
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Renato Botelho
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-04 18:07 UTC by VK
Modified: 2015-01-07 16:20 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback?

Attachments
devel_git.r376291.diff (666 bytes, patch)
2015-01-05 12:55 UTC, VK 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description VK freebsd_triage 2014-12-04 18:07:07 UTC 
The git diff color output is broken because the color sequences are printed instead of being evaluated. The accepted answer here works for me (with default less pager):

http://unix.stackexchange.com/questions/64927/git-diff-displays-colors-incorrectly

I suggest a pkg-message added with a note describing the problem and the fix.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-12-04 18:07:07 UTC 
Auto-assigned to maintainer wxs@FreeBSD.org
Comment 2 VK freebsd_triage 2015-01-05 12:55:26 UTC 
Created attachment 151352 [details]
devel_git.r376291.diff

Adding a patch against the SVN tree (rev 376291) to include a message about configuring git in general, including the pager for broken color output.
Comment 3 commit-hook freebsd_committer freebsd_triage 2015-01-07 16:12:20 UTC 
A commit references this bug:

Author: garga
Date: Wed Jan  7 16:11:27 UTC 2015
New revision: 376467
URL: https://svnweb.freebsd.org/changeset/ports/376467

Log:
  - Add a pkg-message warning user about git diff color being broken with
    default PAGER [1]
  - Add LICENSE
  - Bump PORTREVISION

  PR:		195680 [1]
  Submitted by:	Vlad "Blackflow" K. [1]

Changes:
  head/devel/git/Makefile
  head/devel/git/pkg-message