Bug 195776 - graphics/simage: License/patent clarification needed
Summary: graphics/simage: License/patent clarification needed
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Bartek Rutkowski
URL:
Keywords: patch-ready
Depends on:
Blocks:
 
Reported: 2014-12-07 12:25 UTC by Shane
Modified: 2015-02-27 14:36 UTC (History)
1 user (show)

See Also:


Attachments
graphics/simage license update (618 bytes, patch)
2015-01-27 00:00 UTC, Shane
no flags Details | Diff
graphics/simage license update (2.02 KB, patch)
2015-02-07 03:27 UTC, Shane
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shane 2014-12-07 12:25:16 UTC
graphics/simage

This project is hosted at the same bitbucket account as graphics/Coin and contains the same copyright name but doesn't have the same BSD 3-clause LICENSE file.

The main LICENSE file appears to be an MIT license but doesn't have the copyright notice paragraph, graphics/py-pivy from the same bitbucket account also uses the same LICENSE file and is considered MIT.

Part of the simage code is covered by an MPEG Software Simulation Group license which I'm not certain of a match in the current license list. It contains the sentence "Commercial implementations of MPEG-1 and MPEG-2 video, including shareware, are subject to royalty fees to patent holders."

https://bitbucket.org/Coin3D/simage/src/2c958a61ea8bdfb7f48bf079c899a52f7e92f33a/LICENSE.mpeg2enc?at=default

I expect something like the following should be added to graphics/simage/Makefile

LICENSE_COMB=	dual
LICENSE=	MIT MPEG
LICENSE_PERMS=	no-dist-sell,no-pkg-sell
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-12-07 12:25:16 UTC
Maintainers CC'd
Comment 2 Pedro F. Giffuni freebsd_committer freebsd_triage 2014-12-07 14:53:29 UTC
Hello;

I am not a lawyer and I don't maintain simage so I am not sure why my address was included to this problem report.

A quick look at the Internet would show that apparently there may be an issue though:
https://lists.debian.org/debian-legal/2004/07/msg01537.html
Comment 3 John Marino freebsd_committer freebsd_triage 2015-01-25 18:18:16 UTC
Like Pedro said, there's no maintainer for this port, so just provide a patch for a reasonable license update and it will probably go through.
Comment 4 Shane 2015-01-27 00:00:45 UTC
Created attachment 152221 [details]
graphics/simage license update

This patch updates graphics/simage to fill-in license details.

Part of the source is covered by the mpeg2enc license which states - "Commercial implementations of MPEG-1 and MPEG-2 video, including shareware, are subject to royalty fees to patent holders." I believe the no-dist-sell,no-pkg-sell permissions are relevant to that.

The rest of the code is under an MIT license.
Comment 5 John Marino freebsd_committer freebsd_triage 2015-02-04 10:52:47 UTC
Thanks, I'll promote this as it is, but I'm wondering if it's better to install a copy of the license from files directory rather than pointing to a URL.

I'll let the next committer ponder that.
Comment 6 Shane 2015-02-06 02:07:54 UTC
The licensing for this has been clarified after the last release was tagged so the file isn't included in the used tarball, hence the url.

If there is a way to get a single file from bitbucket then it could be added as an extra distfile.
Comment 7 John Marino freebsd_committer freebsd_triage 2015-02-06 11:35:13 UTC
as I said, you can put the license in the files directory and set LICENSE_FILE to point to it there.

To be clear, I'm talking about "graphics/simage/files".  The distfile and bitbucket doesn't matter.
Comment 8 Shane 2015-02-07 03:27:38 UTC
Created attachment 152651 [details]
graphics/simage license update

Now that I'm awake, here's an update.
Comment 9 John Marino freebsd_committer freebsd_triage 2015-02-07 08:18:39 UTC
do you really want to call the license "unknown"?
I would suggest something like "mpeg-simage".

It's actually listed as "unknown" in the license directory if you do this and I think we can be more descriptive.
Comment 10 John Marino freebsd_committer freebsd_triage 2015-02-07 08:59:44 UTC
actually, the hyphen is probably illegal since the name needs to be part of a variable.  just calling it "simage" is probably good enough (that's unique, right?)
Comment 11 Shane 2015-02-08 06:05:04 UTC
I named it mpeg2enc as it is the mpeg2enc code included that is in question and it matches the license file they include in the simage project.

It would appear that mpegla is the company name behind the license so mpegla may be the more correct naming for it.

If you refer to the unknown in the LICENCE variable, that is the only option for a name not pre-defined in the license structure. Then you use LICENSE_NAME to actually name it.

LICENSE=  MIT unknown
LICENSE_COMB=  dual
LICENSE_NAME_unknown=  mpeg2enc
Comment 12 John Marino freebsd_committer freebsd_triage 2015-02-08 07:53:09 UTC
okay, fair enough.
Comment 13 commit-hook freebsd_committer freebsd_triage 2015-02-27 14:33:54 UTC
A commit references this bug:

Author: robak
Date: Fri Feb 27 14:33:40 UTC 2015
New revision: 380089
URL: https://svnweb.freebsd.org/changeset/ports/380089

Log:
  graphics/simage: add LICENSE

  PR:		195776
  Submitted by:	Shane Ambler <FreeBSD@ShaneWare.Biz>

Changes:
  head/graphics/simage/Makefile
  head/graphics/simage/files/LICENSE.mpeg2enc
Comment 14 Bartek Rutkowski freebsd_committer freebsd_triage 2015-02-27 14:36:06 UTC
Committed, thanks for your work!