Bug 195950 - emulators/virtualbox-ose-additions: vxboxmouse compile error
Summary: emulators/virtualbox-ose-additions: vxboxmouse compile error
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Some People
Assignee: Jung-uk Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-13 18:41 UTC by papowell
Modified: 2014-12-18 22:46 UTC (History)
1 user (show)

See Also:


Attachments
Error Details (5.40 KB, text/plain)
2014-12-13 18:41 UTC, papowell
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description papowell 2014-12-13 18:41:11 UTC
Created attachment 150550 [details]
Error Details

System: FreeBSD amd64 9.3 running under VirtualBox
Date: 13 Dec 2014
Installed all ports using PKGng.  Installed Xorg-7.7_1 using PKGng.  Installed kde-4-14 using PKGng.  X.Org X Server 1.12.4

Compiled: /usr/ports/emulators/virtualbox-ose-additions

In file included from
/usr/ports/emulators/virtualbox-ose-additions/work/VirtualBox-4.3.20/src/VBox/Additions/x11/vbox
mouse/vboxmouse.c:50:
/usr/ports/emulators/virtualbox-ose-additions/work/VirtualBox-4.3.20/src/VBox/Additions/x11/x11i
nclude/xorg-server-1.16.0/xf86Xinput.h:113:
error: redefinition of typedef 'InputInfoPtr'
/usr/ports/emulators/virtualbox-ose-additions/work/VirtualBox-4.3.20/src/VBox/Additions/x11/x11i
nclude/xorg-server-1.16.0/xf86.h:218:
error: previous declaration of 'InputInfoPtr' was here


NOTE 1: the X Server is version 1.12 but the VirtualBox compile appears to use xorg-server-1.16.0.

NOTE 2:  the following patch fixes this problem and the VirtualBox extensions compile and install.


FIX:
diff -bc work/VirtualBox-4.3.20/src/VBox/Additions/x11/x11include/xorg-server-1.16.0/
xf86Xinput.h work.old/VirtualBox-4.3.20/src/VBox/Additions/x11/x11include/xorg-server
-1.16.0/xf86Xinput.h
*** work/VirtualBox-4.3.20/src/VBox/Additions/x11/x11include/xorg-server-1.16.0/xf86X
input.h Fri Nov 21 07:18:44 2014
--- work.old/VirtualBox-4.3.20/src/VBox/Additions/x11/x11include/xorg-server-1.16.0/x
f86Xinput.h Fri Dec 12 08:20:25 2014
***************
*** 85,91 ****
--- 85,94 ----

  /* This is to input devices what the ScrnInfoRec is to screens. */

+ /*
  typedef struct _InputInfoRec {
+ */
+ struct _InputInfoRec {
      struct _InputInfoRec *next;
      char *name;
      char *driver;
***************
*** 110,116 ****
      void *module;
      XF86OptionPtr options;
      InputAttributes *attrs;
! } *InputInfoPtr;
  
  /* xf86Globals.c */
  extern InputInfoPtr xf86InputDevs;
--- 113,123 ----
      void *module;
      XF86OptionPtr options;
      InputAttributes *attrs;
! };
! /*
! *InputInfoPtr;
! */
! //typedef struct _InputInfoRec *InputInfoPtr;
  
  /* xf86Globals.c */
  extern InputInfoPtr xf86InputDevs;
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2014-12-13 22:25:30 UTC
Fix Summary and assign.
Comment 2 papowell 2014-12-14 16:51:47 UTC
I think the problem is related to the compiler used on FreeBSD 9.3 and FreeBSD 10.1.  The compiler used on 9.3 gives an error while the compiler used on 10.1 gives a warning: 'C99 extension...'.
Comment 3 Jung-uk Kim freebsd_committer freebsd_triage 2014-12-18 21:11:45 UTC
I'll take it.
Comment 4 commit-hook freebsd_committer freebsd_triage 2014-12-18 22:45:27 UTC
A commit references this bug:

Author: jkim
Date: Thu Dec 18 22:45:01 UTC 2014
New revision: 374929
URL: https://svnweb.freebsd.org/changeset/ports/374929

Log:
  Add an X.org patch to fix emulators/virtualbox-ose-additions with GCC 4.2.

  http://cgit.freedesktop.org/xorg/xserver/commit?id=ee9f766a

  PR:		195950
  Obtained from:	The X.Org project

Changes:
  head/emulators/virtualbox-ose/files/patch-src-VBox-Additions-x11-x11include-xorg-server-1.16.0-xf86Xinput.h
Comment 5 Jung-uk Kim freebsd_committer freebsd_triage 2014-12-18 22:46:33 UTC
An X.Org patch was committed (r374929).

http://cgit.freedesktop.org/xorg/xserver/commit?id=ee9f766abf6fbe0cc36234bfe727aba924e9b5fd

It should be fixed now.