Created attachment 150645 [details] typo3-7.0.2.patch The old port maintained an 1MB pkg-plist that lists all files from the source-tarball. It is hard to maintain and I cannot see a reason why this port requires a static plist. I adapted www/typo3-lts (dynamic plist) to create this port. - Bug- and security fix - See http://typo3.org/news/article/typo3-cms-4539-629-and-702-released/ - Tests: http://www.charlieroot.de/FreeBSD/PRs/build_www_typo3_2014-12-16-15-29.log
Why change Created by: line? According to svn logs you are not the person that first ported this software. While switching to dynamically generated plist is ok it uses deprecated @dirrmtry keyword. See /usr/ports/CHANGES entry 20140922.
> Why change Created by: line? According to svn logs you are not > the person that first ported this software. I copy&pasted the Makefile from www/typo3-lts. Also, there is almost nothing left from the original Makefile. > While switching to dynamically generated plist is ok it uses > deprecated @dirrmtry keyword. See /usr/ports/CHANGES entry 20140922. Let me check that. I'll upload a new patch soon.
Created attachment 151340 [details] Update to 7.0.2, replace @dirrmtry with @dir - For tests see http://www.charlieroot.de/FreeBSD/PRs/build_www_typo3_2015-01-04-21-25.log
There are still minor issues with this. 1) You can't change the "created by" line (#1). That's an honor for the first person that created the port, it's not something that is updated 2) on the generated plist list, wouldn't the hardcoded "root,wheel" settings break this build for non-root users?
- For tests see http://www.charlieroot.de/FreeBSD/PRs/build_www_typo3_2015-01-21-15-48.log
Created attachment 151968 [details] replace @dirrmtry with @dir
Created attachment 151969 [details] replace @dirrmtry with @dir Hope that patch is OK now :)
Comment on attachment 151968 [details] replace @dirrmtry with @dir Obsolete
most pkg-plist have zero @dir on them. This line, "${FIND} -d * -type d -regex "${TYPO3WWW}/${PORTNAME}-${TYPO3RELEASE}/*.*" | ${SORT} | ${SED} -ne 's#^#@dir #p' >> ${TMPPLIST}" is created one "@dir" for each directory found, right? If so, that's incorrect. You probably don't need any for $TYPO3WWW
I have not found an appropriate documentation for dynamic plists yet, so forgive my ignorance. - an entry for each file is required - a dir() entry for each root directory is required - no entries for sub directories are required, except they have different permissions than the default (root, wheel) - @owner and @group are deprecated by (owner, group, file) and @dir(owner, group, file) So an appropriate plist would look like that: <lots of files> @dir www/typo3-LTS @dir www/typo3_src-6.2.9 @dir(www,www,) www/typo3_src-6.2.9/typo3/ext Is that correct? Are there any preferences in the order of the entries?
(In reply to freebsd-ports from comment #10) > I have not found an appropriate documentation for dynamic plists yet, so forgive my ignorance. It's because dynamic plists are frowned upon. This one is barely acceptable since it's > 6000 entries > - an entry for each file is required yes - a dir() entry for each root directory is required no. Only if it's outside of the $PREFIX or has non-standard ownership/permissions - no entries for sub directories are required, except they have different permissions than the default (root, wheel) this is also true for "root" directories (I'm not sure where "root" distinction comes from) - @owner and @group are deprecated by (owner, group, file) and @dir(owner, group, file) They aren't deprecated. @owner and @group are for files, @dir is for directories Order should be "sort"
Next try: - For tests see http://www.charlieroot.de/FreeBSD/PRs/build_www_typo3_2015-01-22-14-34.log
Created attachment 152013 [details] replace @dirrmtry with @dir, cleanup pkg-plist
That looks fine, so I'm going to promote this to "patch-ready" status for final review and commit. Thanks!
Thank you. I will also apply those changes to www/typo3-lts, shall we re-open PR196482 or create a new PR?
bug 196482 is closed so its better to open a new PR.
this diff is missing the distinfo file!! Can you paste the contents here so we know the generated version matches what you think it should be?
fyi, it build fine if I use this value of distinfo: SHA256 (typo3_src-7.0.2.tar.gz) = 8a88d7758039714aa41bdb9dbfdfc37902aeaed6d1acb4ec53cd34cee4a3fbc8 SIZE (typo3_src-7.0.2.tar.gz) = 21456771 Does that match what you had?
yes, luckily an older version ( attachment 151968 [details] ) has that distinfo file (but not the first version). That's good enough for me but I'm not quite sure what happened there.
A commit references this bug: Author: marino Date: Fri Feb 6 12:37:40 UTC 2015 New revision: 378531 URL: https://svnweb.freebsd.org/changeset/ports/378531 Log: www/typo3: Upgrade version 6.1.9 => 7.0.2 While here, convert large static pkg-plist (> 9000 lines) to be dynamically generated. PR: 196028 Submitted by: maintainer (freebsd-ports - charlieroot.de) Changes: head/www/typo3/Makefile head/www/typo3/distinfo head/www/typo3/pkg-descr head/www/typo3/pkg-plist
done, thanks.
Sorry for the confusion and thanks for commiting.