Bug 196069 - [wpi] [patch]: refactor wpi_scan()
Summary: [wpi] [patch]: refactor wpi_scan()
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: wireless (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-wireless (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-17 17:43 UTC by Andriy Voskoboinyk
Modified: 2014-12-20 20:08 UTC (History)
1 user (show)

See Also:

Attachments
Patch for if_wpi.c (wpi_scan()) / if_wpireg.h (3.09 KB, patch)
2014-12-17 17:43 UTC, Andriy Voskoboinyk 		no flags Details | Diff
Patch for if_wpi.c (wpi_scan()) / if_wpireg.h (2.57 KB, patch)
2014-12-19 12:03 UTC, Andriy Voskoboinyk 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andriy Voskoboinyk freebsd_committer freebsd_triage 2014-12-17 17:43:29 UTC 
Created attachment 150686 [details]
Patch for if_wpi.c (wpi_scan()) / if_wpireg.h

- Use macros instead of numbers.
- Replace code with function call.
Comment 1 Adrian Chadd freebsd_committer freebsd_triage 2014-12-17 19:07:23 UTC 
Hi!

I think it's about time that "add ssid" method just got added somewhere in net80211.

Want to do that? I think that's the better solution.

Then I'll commit it! It's likely we can then use that particular routine from a variety of other drivers.

Thanks!



-adrian
Comment 2 Adrian Chadd freebsd_committer freebsd_triage 2014-12-19 01:48:42 UTC 
ok, would you now submit a replacement patch with the new public ieee80211_add_ssid () ?


Thanks!
Comment 3 Andriy Voskoboinyk freebsd_committer freebsd_triage 2014-12-19 12:03:11 UTC 
Created attachment 150752 [details]
Patch for if_wpi.c (wpi_scan()) / if_wpireg.h

Rebase against HEAD.
Comment 4 Adrian Chadd freebsd_committer freebsd_triage 2014-12-20 20:07:56 UTC 
Committed, thanks!
Comment 5 commit-hook freebsd_committer freebsd_triage 2014-12-20 20:08:31 UTC 
A commit references this bug:

Author: adrian
Date: Sat Dec 20 20:07:49 UTC 2014
New revision: 275966
URL: https://svnweb.freebsd.org/changeset/base/275966

Log:
  Remove some hard-coded IE assembly over to use net80211 methods.

  PR:		kern/196069
  Submitted by:	 Andriy Voskoboinyk <s3erios@gmail.com>

Changes:
  head/sys/dev/wpi/if_wpi.c
  head/sys/dev/wpi/if_wpireg.h