Bug 196080 - www/seamonkey - fix the LDAP option
Summary: www/seamonkey - fix the LDAP option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-gecko (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-17 23:48 UTC by Mikhail T.
Modified: 2015-01-21 17:38 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (gecko)


Attachments
Fix dependency generation for bundled shared libraries (1.80 KB, patch)
2014-12-17 23:48 UTC, Mikhail T.
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail T. 2014-12-17 23:48:17 UTC
Created attachment 150702 [details]
Fix dependency generation for bundled shared libraries

Adding the proposed patch fixes the dependency-generation so that the LDAP-libraries are properly found at run-time. This unbreaks the LDAP-option and even allows to turn it on by default. I submitted the patch upstream already:

https://bugzilla.mozilla.org/show_bug.cgi?id=1112904


Another hunk removes the seamonkey-bin, which is created as a copy of seamonkey. I'm too lazy to hunt down the underlying reason for the bogus copying...
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-12-17 23:48:17 UTC
Auto-assigned to maintainer gecko@FreeBSD.org
Comment 2 Mikhail T. 2014-12-31 03:32:00 UTC
While the discussion upstream is ongoing on how to fix this problem for good -- or, whether to, perhaps, make the c-sdk subtree of mozilla build separately (like NSPR and NSS), our port remains broken.

I think, my patch is a perfectly fine short- to medium-term solution. Please, commit at your convenience or allow me to. Thanks!
Comment 3 Jan Beich freebsd_committer freebsd_triage 2014-12-31 05:47:36 UTC
(In reply to Mikhail T. from comment #2)
> While the discussion upstream is ongoing on how to fix this problem for good
> -- or, whether to, perhaps, make the c-sdk subtree of mozilla build
> separately (like NSPR and NSS), our port remains broken.

LDAP is already configured and built using mostly its own build system. And as you can see in the log only a few more libs are built this way, the rest are converted to moz.build. But adding --with-system-ldap to mail/thunderbird and www/seamonkey and making them depend on net/ldapsdk wouldn't solve this and Mozilla bug 925217. It may also make things worse by having to either roll our own distfile or be satisfied with the one from 31-Jan-2011.

  ldap/sdks/c-sdk> checking for as... (cached) /usr/bin/as
  ldap/sdks/c-sdk> checking for ar... /usr/bin/ar
  ldap/sdks/c-sdk> checking for ld... /usr/bin/ld
  ldap/sdks/c-sdk> checking for strip... /usr/bin/strip
  [...]
  ldap/sdks/c-sdk> creating ./config.status
  ldap/sdks/c-sdk> creating Makefile
  ldap/sdks/c-sdk> creating config/Makefile
  ldap/sdks/c-sdk> creating config/autoconf.mk
  ldap/sdks/c-sdk> creating ldap/Makefile
  ldap/sdks/c-sdk> creating ldap/clients/tools/Makefile
  ldap/sdks/c-sdk> creating ldap/include/Makefile
  ldap/sdks/c-sdk> creating ldap/libraries/Makefile
  ldap/sdks/c-sdk> creating ldap/libraries/libldap/Makefile
  ldap/sdks/c-sdk> creating ldap/libraries/libprldap/Makefile

https://ftp.mozilla.org/pub/mozilla.org/thunderbird/try-builds/jbeich@vfemail.net-16fd61cbacf9/try-comm-central-linux/try-comm-central-linux-bm87-try1-build46.txt.gz

  $ cd net/ldapsdk; make install

  $ ls -l /usr/local/mozilla/directory/bin/
  total 2
  lrwxr-xr-x  1 root  wheel  63 Dec 31 14:40 libldap60.so@ -> ../../mozldap-6.0.7/c-sdk/ldap/libraries/libldap/./libldap60.so
  lrwxr-xr-x  1 root  wheel  63 Dec 31 14:39 libldif60.so@ -> ../../mozldap-6.0.7/c-sdk/ldap/libraries/libldif/./libldif60.so
  lrwxr-xr-x  1 root  wheel  67 Dec 31 14:40 libprldap60.so@ -> ../../mozldap-6.0.7/c-sdk/ldap/libraries/libprldap/./libprldap60.so

  $ ls -l /usr/local/mozilla/directory/lib/*.so*
  lrwxr-xr-x  1 root  wheel  63 Dec 31 14:40 /usr/local/mozilla/directory/lib/libldap60.so@ -> ../../mozldap-6.0.7/c-sdk/ldap/libraries/libldap/./libldap60.so
  lrwxr-xr-x  1 root  wheel  63 Dec 31 14:39 /usr/local/mozilla/directory/lib/libldif60.so@ -> ../../mozldap-6.0.7/c-sdk/ldap/libraries/libldif/./libldif60.so
  lrwxr-xr-x  1 root  wheel  67 Dec 31 14:40 /usr/local/mozilla/directory/lib/libprldap60.so@ -> ../../mozldap-6.0.7/c-sdk/ldap/libraries/libprldap/./libprldap60.so

> I think, my patch is a perfectly fine short- to medium-term solution.
> Please, commit at your convenience or allow me to. Thanks!

Can you test my version first?

https://trillian.chruetertee.ch/freebsd-gecko/changeset/1796/
Comment 4 Jan Beich freebsd_committer freebsd_triage 2015-01-21 17:38:04 UTC
Landed as ports r377062.