Bug 196123 - games/rnd_jue: cleanup
Summary: games/rnd_jue: cleanup
Status: Closed Not Accepted
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Rusmir Dusko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-19 13:17 UTC by Dmitry Marakasov
Modified: 2014-12-23 03:34 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (nemysis)


Attachments
games/rnd_jur patch (15.22 KB, patch)
2014-12-19 13:17 UTC, Dmitry Marakasov
no flags Details | Diff
games/3omns patch (1.28 KB, patch)
2014-12-19 13:18 UTC, Dmitry Marakasov
amdmi3: maintainer-approval? (nemysis)
Details | Diff
games/netwalk patch (663 bytes, patch)
2014-12-19 13:18 UTC, Dmitry Marakasov
amdmi3: maintainer-approval?
Details | Diff
games/pacmanarena patch (709 bytes, patch)
2014-12-19 13:19 UTC, Dmitry Marakasov
no flags Details | Diff
games/sdlskk patch (512 bytes, patch)
2014-12-19 13:19 UTC, Dmitry Marakasov
no flags Details | Diff
games/twind patch (1.07 KB, patch)
2014-12-19 13:19 UTC, Dmitry Marakasov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer freebsd_triage 2014-12-19 13:17:22 UTC
Created attachment 150755 [details]
games/rnd_jur patch

Hi!

I continue my cleanup of ports to get rid of stage-qa, plist and, if possible, portlint warnings. I've got many your ports on queue, here's a submission for games/rnd_jue:

- Simplify installation
  - Get rid of that DOCSDIR2 nonsence, which may be replaced by a single COPYTREE command
  - Don't generate plist by hand as it may be done with PORTDATA=*
- Drop @dirrm* from plist
- Add empty directory to plist

Attached are other patch examples, including following changes:
- Add or clarify license (LICENSE=GPL3 -> LICENSE=GPL3 # or later
- Add LICENSE_FILE
- Drop @dirrm* from plist
- Fix strip (where INSTALL_TARGET=install-strip doesn't work)
- Switch to USES=autoreconf

So, if these are ok, would you like me to
- submit a PR for each such change?
- submit a bunch of such changes in a single PR?
- just commit these and similar changes right away (of course I test these as I do with my ports)?
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-12-19 13:17:22 UTC
Auto-assigned to maintainer nemysis@FreeBSD.org
Comment 2 Dmitry Marakasov freebsd_committer freebsd_triage 2014-12-19 13:18:01 UTC
Created attachment 150756 [details]
games/3omns patch
Comment 3 Dmitry Marakasov freebsd_committer freebsd_triage 2014-12-19 13:18:28 UTC
Created attachment 150757 [details]
games/netwalk patch
Comment 4 Dmitry Marakasov freebsd_committer freebsd_triage 2014-12-19 13:19:05 UTC
Created attachment 150758 [details]
games/pacmanarena patch
Comment 5 Dmitry Marakasov freebsd_committer freebsd_triage 2014-12-19 13:19:21 UTC
Created attachment 150759 [details]
games/sdlskk patch
Comment 6 Dmitry Marakasov freebsd_committer freebsd_triage 2014-12-19 13:19:37 UTC
Created attachment 150760 [details]
games/twind patch
Comment 7 Rusmir Dusko freebsd_committer freebsd_triage 2014-12-20 10:02:18 UTC
Please make for each Ports one Request. Not more to be clean
Comment 8 Dmitry Marakasov freebsd_committer freebsd_triage 2014-12-23 03:34:05 UTC
(Fix resolution)