Bug 196184 - japanese/ebview-gtk2: Size mismatch between int and ssize_t in amd64
Summary: japanese/ebview-gtk2: Size mismatch between int and ssize_t in amd64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Some People
Assignee: John Marino
URL:
Keywords: patch-ready
Depends on:
Blocks:
 
Reported: 2014-12-22 08:09 UTC by moga
Modified: 2015-01-20 21:48 UTC (History)
2 users (show)

See Also:


Attachments
This patch solves the problem. (1.55 KB, patch)
2014-12-22 08:09 UTC, moga
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description moga 2014-12-22 08:09:21 UTC
Created attachment 150843 [details]
This patch solves the problem.

Because of the size mismatch between int and ssize_t, the value given by a
pointer to int destroys an adjacent value when it would be written as the
pointer to ssize_t.  Some values defined in src/eb.c are referenced as 
the values of ssize_t in libeb functions, causing a segmentation fault or
incorrect search results.
Comment 1 John Marino freebsd_committer freebsd_triage 2015-01-15 11:03:41 UTC
This should have been a patch to the port, not the software.

I think somebody could rename the file to patch-src_eb.c and stick it in files.  However, it would have been better to submit a patch against the port that creates that patch file.

The port is unmaintained.
The patch has no test logs, but they wouldn't help much as it fixes a runtime problem.

Move to patch-ready state.
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-01-20 21:47:53 UTC
A commit references this bug:

Author: marino
Date: Tue Jan 20 21:47:16 UTC 2015
New revision: 377542
URL: https://svnweb.freebsd.org/changeset/ports/377542

Log:
  japanese/ebview-gtk2: Fix size mismatch between int and ssize_t (amd64)

  This fetchs the source of segfaults on amd64.

  PR:		196184
  Submitted by:	moga (chigusa.homeunix.org)

Changes:
  head/japanese/ebview-gtk2/Makefile
  head/japanese/ebview-gtk2/files/patch-src_eb.c
Comment 3 John Marino freebsd_committer freebsd_triage 2015-01-20 21:48:44 UTC
Thanks!