Created attachment 150896 [details] textproc/smi Simple Markup Interpreter textproc/smi Simple Markup Interpreter / filter for simple markup replaces textproc/smu, which hasn't been fetchable for ~5yrs. Interprets Markdown, HTML, and [portions of] others. Please find shar(1) file, attached, for source. Please also find requisite QA, also attached. Thank you for all your time, and consideration. --Chris TAGS: EASY TRIVIAL TESTED RISK-FREE
Created attachment 150897 [details] textproc/smi -- requisite QA Requisit QA for textproc/smi
Created attachment 150900 [details] textproc/smi Simple Markup Interpreter Updated man page, which required a re-pack, which required distinfo be updated, ... you know the drill. :) This is final, and obsoletes previous. Thanks! --Chris
This pr is over 30 days old. Is anything else missing, or needed to commit this? If so, please advise. Thanks. --Chris
(In reply to Chris Hutchinson from comment #3) Take the PR as reminder to myself. Chris, I don't see anything major upon a quick visual inspection but once I finish a more in depth QA I will provide feedback, if any.
Created attachment 160713 [details] Poudriere testport log from 10.1-RELEASE jail I tested on all supported releases and CURRENT. No issues noted and the port appears to work as intended at runtime. Review submitted at https://reviews.FreeBSD.org/D3569
Hi Chris, There is some feedback in the above mentioned review. I don't have any issue making adjustments. However with the original SMU on Github now (https://github.com/Gottox/smu) and having a 1.4 release of their own it feels like the most correct solution is to spend time toward updating the textproc/smu port. Any thoughts?
(In reply to Jason Unovitch from comment #6) > Hi Chris, > There is some feedback in the above mentioned review. I don't have any issue > making adjustments. However with the original SMU on Github now > (https://github.com/Gottox/smu) and having a 1.4 release of their own it > feels like the most correct solution is to spend time toward updating the > textproc/smu port. Any thoughts? I have actually done quite a bit of [re]work to this, since I initiated this pr(1) ~9 months ago. Including a web based editor. I had intended to commit these changes after it was imported into the FreeBSD ports tree. At the time, it seemed smu was dead. But if that's not the case, than let it live. Maybe it best I just start a new pr(1) with everything I now have implemented as a new port. Feel free to close this. --Chris
(In reply to Chris Hutchinson from comment #7) Ok, it sounds like it would be worth pursing this PR if you have new features distinct from textproc/smu. Can you have a look at the comments on https://reviews.FreeBSD.org/D3569 and make an update to address them?
Differential review updated to address comments. Mainly this change addresses smi complying with user defined PREFIX and MANPREFIX and ensuring it can't globally replace after instance of 'cc' whether intentional or not. ${REINPLACE_CMD} -e 's|^CC = .*|CC = ${CC}|' \ -e 's|^PREFIX = .*|PREFlX = ${PREFIX}|' \ -e 's|^MANPREFIX = .*|MANPREFIX = ${MANPREFIX}|' \ ${WRKSRC}/config.mk
A commit references this bug: Author: junovitch Date: Thu Sep 10 00:45:27 UTC 2015 New revision: 396547 URL: https://svnweb.freebsd.org/changeset/ports/396547 Log: New Port: textproc/smi Smi is a Simple Markup Interpreter / filter for simplified Markup dialect. smi can be fed text in Markdown, and return HTML output. smi can be fed HTML, and return the markup translated to entities. I use smi as a filter for devel/cgit to parse the README.md files, returning HTML output. I am also using it to markup wiki pages, for a git backed wiki. The use cases are limited only by your imagination. WWW: http://BSDforge.com/projects/textproc/smi/ PR: 196224 Submitted by: Chris Hutchinson <portmaster@bsdforge.com> Approved by: pgollucci (mentor) Differential Revision: https://reviews.freebsd.org/D3569 Changes: head/textproc/Makefile head/textproc/smi/ head/textproc/smi/Makefile head/textproc/smi/distinfo head/textproc/smi/pkg-descr
(In reply to Chris Hutchinson from comment #7) Chris, Thanks! Go ahead and open up that PR for your next version with the new features when you are able.
Set open pending QA fixes.
Created attachment 160885 [details] smi-1.4_1.patch -- corrections
(In reply to Jason Unovitch from comment #13) > Created attachment 160885 [details] > smi-1.4_1.patch -- corrections Looks good to me. Go ahead. Thanks, Jason! --Chris
Committed as 396547.
A commit references this bug: Author: junovitch Date: Tue Sep 15 15:04:54 UTC 2015 New revision: 396965 URL: https://svnweb.freebsd.org/changeset/ports/396965 Log: textproc/smi: Remove PREFIX and MANPREFIX edits inherited through MAKE_ENV PR: 196224 Reported by: jbeich Changes: head/textproc/smi/Makefile
The fixup noted on the mailing list has been committed so closing the PR (again). Chris, let's go with the "CC ?= cc" style config.mk syntax that properly inherits from MAKE_ENV on your next update of the port. That way the the post-patch: routine won't be needed and can be cleaned up.
(In reply to Jason Unovitch from comment #17) > The fixup noted on the mailing list has been committed so closing the PR > (again). > > Chris, let's go with the "CC ?= cc" style config.mk syntax that properly > inherits from MAKE_ENV on your next update of the port. That way the the > post-patch: routine won't be needed and can be cleaned up. Sounds like the perfect solution. Thank you, Jason, for all the work you put into this! Greatly appreciated! --Chris