Bug 196249 - net/ortp: Build with encryption support
Summary: net/ortp: Build with encryption support
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Maxim Sobolev
URL:
Keywords: needs-qa, patch
Depends on: 196248
Blocks:
  Show dependency treegraph
 
Reported: 2014-12-24 07:44 UTC by Mikhail T.
Modified: 2018-01-10 09:59 UTC (History)
4 users (show)

See Also:
koobs: maintainer-feedback? (sobomax)


Attachments
Build ortp with srtp and zrtp support (1.49 KB, patch)
2014-12-24 07:44 UTC, Mikhail T.
koobs: maintainer-approval? (sobomax)
Details | Diff
alternate patch (3.23 KB, patch)
2015-01-01 13:39 UTC, Tijl Coosemans
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail T. 2014-12-24 07:44:30 UTC
Created attachment 150934 [details]
Build ortp with srtp and zrtp support

The port currently builds with support for neither srtp nor zrtp protocols, which leads to encryption being unavailable in linphone.

This patch -- to be applied after the Bug 196248 is resolved as I expect -- will make use of both libsrtp and libzrtpcpp in ortp.
Comment 1 Tijl Coosemans freebsd_committer freebsd_triage 2015-01-01 13:39:14 UTC
Created attachment 151191 [details]
alternate patch

net/ortp only needs libzrtpcppcore instead of libzrtpcpp.  I've created a new port security/libzrtpcppcore which net/ortp can depend on.  This patch also makes the SRTP and ZRTP support optional.

CPPFLAGS+=-DHAVE_DEV_RANDOM can also be removed because on FreeBSD arc4random is used instead of /dev/random.
Comment 2 Mikhail T. 2015-01-01 16:20:37 UTC
(In reply to Tijl Coosemans from comment #1)
> net/ortp only needs libzrtpcppcore instead of libzrtpcpp. I've created a
> new port security/libzrtpcppcore which net/ortp can depend on.

I don't know, if that was wise -- are there a lot of use-cases, where only libzrtpcppcore is needed? Is libzrtpcpp MUCH bigger and/or does it require many more dependencies?

> This patch also makes the SRTP and ZRTP support optional.

Is this warranted? You have enabled them by default, which is good, but should they be optional -- and require the users to answer yet more questions, when building? Why would anybody want to disable them?
Comment 3 Tijl Coosemans freebsd_committer freebsd_triage 2015-01-02 13:19:24 UTC
(In reply to Mikhail T. from comment #2)
> (In reply to Tijl Coosemans from comment #1)
>> net/ortp only needs libzrtpcppcore instead of libzrtpcpp. I've created a
>> new port security/libzrtpcppcore which net/ortp can depend on.
> 
> I don't know, if that was wise -- are there a lot of use-cases, where only
> libzrtpcppcore is needed? Is libzrtpcpp MUCH bigger and/or does it require
> many more dependencies?

libzrtpcppcore does not have any dependencies.  It is purely about ZRTP, while libzrtpcpp depends on ccrtp (and its dependencies) and is about SRTP+ZRTP.  Since net/ortp used libsrtp for SRTP support, it only needs libzrtpcppcore.
 
>> This patch also makes the SRTP and ZRTP support optional.
> 
> Is this warranted? You have enabled them by default, which is good, but
> should they be optional -- and require the users to answer yet more
> questions, when building? Why would anybody want to disable them?

libzrtpcppcore is now LGPL3 instead of GPL3, so yes, maybe it doesn't need to be optional.
Comment 4 Mikhail Teterin freebsd_committer freebsd_triage 2015-01-03 03:21:25 UTC
(In reply to Tijl Coosemans from comment #3)

Tijl, please, go ahead in the fashion you deem best -- I think, you've given this a lot of thought. All I really care for is to have an encryption-capable linphone :-)

BTW, perhaps, you should take maintainership of the linphone port?

Thank you!
Comment 5 Walter Schwarzenfeld freebsd_triage 2018-01-10 07:04:50 UTC
Any advance here? and is it still relevant?
Comment 6 Tijl Coosemans freebsd_committer freebsd_triage 2018-01-10 09:59:33 UTC
SRTP/ZRTP support has been moved from oRTP to Mediastreamer.