Bug 196389 - makefs(8): when populating METALOG with symlink information, no default user/group is populated
Summary: makefs(8): when populating METALOG with symlink information, no default user/...
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: misc (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-bugs (Nobody)
URL:
Keywords: install
Depends on:
Blocks:
 
Reported: 2014-12-30 21:24 UTC by Adrian Chadd
Modified: 2025-01-21 22:43 UTC (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Chadd freebsd_committer freebsd_triage 2014-12-30 21:24:43 UTC
When doing a non-root user build, install gets run to populate symlinks.

The build is calling INSTALL_SYMLINK to do the dirty work.

This doesn't provide user/group information, so the entry in METALOG looks like this:

./sys type=link mode=0755 link=usr/src/sys

.. and makefs then populates it as the user in question from the filesystem, and you end up with this in the image:

root@raspberry-pi:~ # ls -l /sys
lrwxr-xr-x  1 adrian  adrian  11 Dec 29 01:59 /sys -> usr/src/sys

(I added adrian:adrian to the raspberry pi image later, so the user/group resolves to the name. But it'll show up as 1001:1001 normally as that's my uid/gid.)
Comment 1 Graham Perrin freebsd_committer freebsd_triage 2022-12-31 10:12:14 UTC
Is this still an issue?
Comment 2 Ed Maste freebsd_committer freebsd_triage 2023-04-18 17:42:34 UTC
(In reply to Graham Perrin from comment #1)
> Is this still an issue?

I have no reason to expect this has changed.
Comment 3 Ed Maste freebsd_committer freebsd_triage 2025-01-21 22:43:14 UTC
(In reply to Ed Maste from comment #2)
> I have no reason to expect this has changed.

Ah, I was mistaken:

commit fa8c921e3f372be81d07f7e2fb6f05186557a651
Author: Brooks Davis <brooks@FreeBSD.org>
Date:   Fri Jun 29 16:07:56 2018 +0000

    Correct link metadata created when installing with -DNO_ROOT.
    
    Explicitly specify owner/group/mode metadata when creating links.
    
    More consistently use INSTALL_SYMLINK to install symlinks.
    
    Reviewed by:    bdrewery
    Sponsored by:   DARPA, AFRL
    Differential Revision:  https://reviews.freebsd.org/D11231