Bug 196419 - devel/efl broken for days, taking out 33 enlightenment ports with it
Summary: devel/efl broken for days, taking out 33 enlightenment ports with it
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Grzegorz Blach
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-01 12:58 UTC by John Marino
Modified: 2015-01-02 06:46 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (gblach)


Attachments
failed attempt at fixing efl, but it least it configures with it (491 bytes, patch)
2015-01-01 12:58 UTC, John Marino
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Marino freebsd_committer 2015-01-01 12:58:42 UTC
Created attachment 151189 [details]
failed attempt at fixing efl, but it least it configures with it

DragonFly has been seeing the same configuration error FreeBSD is:




checking whether c++ supports C++11 features by default... no
checking whether c++ supports C++11 features with -std=gnu++11... yes
configure: Finished Eina_Cxx checks
configure: Start Eet checks
checking for libjpeg... yes
checking for zlib... yes
checking for EET... no
configure: error: Package requirements ( ) were not met:

Please specify at least one package name on the command line.

Consider adjusting the PKG_CONFIG_PATH environment variable if you
installed software in a non-standard prefix.

Alternatively, you may set the environment variables EET_CFLAGS
and EET_LIBS to avoid the need to call pkg-config.
See the pkg-config man page for more details.
===>  Script "configure" failed unexpectedly.




Applying the attached patch gets efl to configure, but it later fails to find headers it is supposed to install:



  CC       static_libs/lz4/lib_evas_libevas_la-lz4hc.lo
  CC       lib/evas/common/evas_op_blend/lib_evas_common_libevas_op_blend_sse3_la-op_blend_master_sse3.lo
  CC       lib/eet/lib_eet_libeet_la-eet_alloc.lo
  CC       lib/eet/lib_eet_libeet_la-eet_cipher.lo
lib/eet/eet_alloc.c:5:18: fatal error: Eina.h: No such file or directory
compilation terminated.
Makefile:21658: recipe for target 'lib/eet/lib_eet_libeet_la-eet_alloc.lo' failed
gmake[5]: *** [lib/eet/lib_eet_libeet_la-eet_alloc.lo] Error 1
gmake[5]: *** Waiting for unfinished jobs....
In file included from lib/eet/eet_cipher.c:49:0:
lib/eet/Eet.h:99:18: fatal error: Eina.h: No such file or directory
compilation terminated.
Makefile:21665: recipe for target 'lib/eet/lib_eet_libeet_la-eet_cipher.lo' failed
gmake[5]: *** [lib/eet/lib_eet_libeet_la-eet_cipher.lo] Error 1
Makefile:31925: recipe for target 'all-recursive' failed
gmake[4]: *** [all-recursive] Error 1
Makefile:11585: recipe for target 'all' failed
gmake[3]: *** [all] Error 2
Makefile:2284: recipe for target 'all-recursive' failed
gmake[2]: *** [all-recursive] Error 1
Makefile:1514: recipe for target 'all' failed
gmake[1]: *** [all] Error 2
gmake[1]: Leaving directory '/wrkdirs/devel/efl/work/efl-1.12.2'
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** Error code 1

Stop.
make: stopped in /usr/ports/devel/efl



The recent breakage of efl means that none of the enlighenment ports can be be built.  package fallout must have warned about this.  Is there any estimated time this desktop will be restored?
Comment 1 Bugzilla Automation freebsd_committer 2015-01-01 12:58:42 UTC
Auto-assigned to maintainer gblach@FreeBSD.org
Comment 2 Grzegorz Blach freebsd_committer 2015-01-01 23:53:46 UTC
I tried to repeat reported problem on 8 systems (different FreeBSD versions), but everywhere I can build EFL correctly.  Configure error which you presented looks like you don't have all required libraries installed.

Please send me full output from `make` command, your /etc/make.conf and version of your system.
Comment 3 John Marino freebsd_committer 2015-01-02 00:19:11 UTC
(In reply to Grzegorz Blach from comment #2)
> I tried to repeat reported problem on 8 systems (different FreeBSD
> versions), but everywhere I can build EFL correctly.  Configure error which
> you presented looks like you don't have all required libraries installed.

How do you explain the failures seen on portsmon?
http://beefy2.isc.freebsd.org/bulk/10amd64-default/latest/logs/errors/efl-1.12.2_3.log
http://beefy1.isc.freebsd.org/bulk/10i386-default/latest/logs/errors/efl-1.12.2_3.log

This is FreeBSD 10, official builders.

> 
> Please send me full output from `make` command, your /etc/make.conf and
> version of your system.

Like portsmon, I am building in a clean jail of poudriere.
Are you not also testing using poudriere before committing?

Did you not receive pkg-fallout messages when they failed above?
Comment 4 Grzegorz Blach freebsd_committer 2015-01-02 00:48:42 UTC
Currently I can't explain what is a reason of this bug.  I've received pkg-fallout logs, but on my local poudriere on clean environment everything is ok:
https://people.freebsd.org/~gblach/logs/10.1-amd64-efl-1.12.2_3.log
https://people.freebsd.org/~gblach/logs/10.1-i386-efl-1.12.2_3.log

Before I can fix this bug I need to understand what is a reason.  Currently I have no idea what could be wrong.  Any suggestion might be helpful.
Comment 5 John Marino freebsd_committer 2015-01-02 01:08:51 UTC
well, efl configure script is checking for EET as an already installed library, which no longer exists in ports.

The patch that I attached here removed this check from the configure script, but then it fails during building (missing -I cflag apparently).

I don't know why it's passing for you, unless your ports tree is not up to date.
Comment 6 Grzegorz Blach freebsd_committer 2015-01-02 01:15:03 UTC
I have some idea, I checked EFL on 8.4, 9.3 and 10.1, but not on 10.0 (pkg-fallout reports bug on this release).

Maybe this patch resolve problem:

--- Makefile    (revision 376034)
+++ Makefile    (working copy)
@@ -109,7 +109,7 @@
 
 .if ${PORT_OPTIONS:MSSL}
 USE_OPENSSL=                   yes
-. if ${OSVERSION} >= 1000000
+. if ${OSVERSION} >= 1001000
 EXTRA_PATCHES+=                        ${FILESDIR}/extra-patch-configure.ac
 CONFIGURE_ENV+=                        ECORE_CON_CFLAGS="-I${OPENSSLINC} -L${OPENSSLLIB}" ECORE_CON_LIBS="-lssl"
 . else


I'm checking now.
Comment 7 John Marino freebsd_committer 2015-01-02 01:53:09 UTC
that would also explain why it's busted on DragonFly.

OSVERSION is supposed to be used together with OPSYS, e.g.

. if ${OPSYS} == FreeBSD && ${OSVERSION} >= 1001000

instead of

+. if ${OSVERSION} >= 1001000
Comment 8 commit-hook freebsd_committer 2015-01-02 02:14:20 UTC
A commit references this bug:

Author: gblach
Date: Fri Jan  2 02:13:51 UTC 2015
New revision: 376037
URL: https://svnweb.freebsd.org/changeset/ports/376037

Log:
  - On FreeBSD 10.0 use OpenSSL from ports
  - Check OPSYS together with OSVERSION [1]

  PR:		196419
  Submitted by:	marino [1]

Changes:
  head/devel/efl/Makefile
Comment 9 Grzegorz Blach freebsd_committer 2015-01-02 02:15:40 UTC
Bugfix committed, thanks.
Comment 10 commit-hook freebsd_committer 2015-01-02 06:46:41 UTC
A commit references this bug:

Author: antoine
Date: Fri Jan  2 06:46:01 UTC 2015
New revision: 376040
URL: https://svnweb.freebsd.org/changeset/ports/376040

Log:
  MFH: r376037

  - On FreeBSD 10.0 use OpenSSL from ports
  - Check OPSYS together with OSVERSION [1]

  PR:		196419
  Submitted by:	marino [1]

Changes:
_U  branches/2015Q1/
  branches/2015Q1/devel/efl/Makefile