Bug 196598 - makefs option typo
Summary: makefs option typo
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: 10.1-STABLE
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-12 16:44 UTC by Dan McGregor
Modified: 2015-01-19 11:01 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dan McGregor 2015-01-12 16:44:27 UTC 

Environment:
FreeBSD 10.1-STABLE

makefs has a typo in its handling of the maxbpg option for ffs. It is parsing
maxbpf instead.

# makefs -t ffs -o version=2,maxbpg=4096 -s 4g -N etc ../rootfs METALOG
makefs: Unknown option `maxbpg'
Comment 1 Gavin Atkinson freebsd_committer freebsd_triage 2015-01-12 18:45:13 UTC 
Hi,

Due to an issue with the backend FreeBSD Bugzilla database, your original PR and any updates to it since have been lost.  I've recreated the original PR as best as I can, however any attachments and updates you submitted to the PR have been lost.  Please could you resubmit them?

Thanks, and apologies.
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-01-12 19:26:57 UTC 
A commit references this bug:

Author: brueffer
Date: Mon Jan 12 19:26:32 UTC 2015
New revision: 277085
URL: https://svnweb.freebsd.org/changeset/base/277085

Log:
  Fix a typo in the FFS maxbpg option, it was erroneously spelled maxbpf.

  The error exists in the NetBSD upstream version as well and will be reported back.

  PR:		196598
  Submitted by:	Dan McGregor
  MFC after:	1 week

Changes:
  head/usr.sbin/makefs/ffs.c
Comment 3 Dan McGregor 2015-01-12 21:54:13 UTC 
(In reply to Gavin Atkinson from comment #1)
Thanks for the message, Gavin.

I updated nothing and the original attachment was a patch identical to what was committed in r277085 by brueffer.
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-01-19 10:57:46 UTC 
A commit references this bug:

Author: brueffer
Date: Mon Jan 19 10:57:01 UTC 2015
New revision: 277375
URL: https://svnweb.freebsd.org/changeset/base/277375

Log:
  MFH: r277085

  Fix a typo in the FFS maxbpg option, it was erroneously spelled maxbpf.

  The error has been reported to and fixed in the NetBSD upstream version as well.

  PR:             196598
  Submitted by:   Dan McGregor

Changes:
_U  stable/10/
  stable/10/usr.sbin/makefs/ffs.c
Comment 5 commit-hook freebsd_committer freebsd_triage 2015-01-19 10:59:48 UTC 
A commit references this bug:

Author: brueffer
Date: Mon Jan 19 10:58:53 UTC 2015
New revision: 277376
URL: https://svnweb.freebsd.org/changeset/base/277376

Log:
  MFH: r277085

  Fix a typo in the FFS maxbpg option, it was erroneously spelled maxbpf.

  The error has been reported to and fixed in the NetBSD upstream version as well.

  PR:             196598
  Submitted by:   Dan McGregor

Changes:
_U  stable/9/usr.sbin/makefs/
  stable/9/usr.sbin/makefs/ffs.c
Comment 6 Christian Brueffer freebsd_committer freebsd_triage 2015-01-19 11:01:06 UTC 
Fixed in HEAD, 10-STABLE and 9-STABLE.  Thanks for the submission!