Bug 196663 - devel/libgit2-glib: unbreak and update to 0.0.24
Summary: devel/libgit2-glib: unbreak and update to 0.0.24
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-12 21:46 UTC by Ruslan Makhmatkhanov
Modified: 2015-01-15 12:22 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (gnome)

Attachments
unbreak libgit2-glib (5.19 KB, patch)
2015-01-12 21:46 UTC, Ruslan Makhmatkhanov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2015-01-12 21:46:24 UTC 
Created attachment 151508 [details]
unbreak libgit2-glib

- fix build
- update to 0.0.24
- remove MAKE_JOBS_UNSAFE
- sort pkg-plist

It is better to apply this after PR 196662 is committed, because it is adding threads support. PR 196177 actually not fixing the build. 

Build log is here: http://people.freebsd.org/~rm/libgit2-glib-0.0.24.log
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2015-01-12 21:46:24 UTC 
Auto-assigned to maintainer gnome@FreeBSD.org
Comment 2 Dmitry Marakasov freebsd_committer freebsd_triage 2015-01-15 09:48:54 UTC 
What's the purpose of the patch? Otherwise duplicate of 196177.
Comment 3 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2015-01-15 10:12:17 UTC 
Purpose is the fixing of this build errors (see the build log in 196177):
"""
gmake[3]: Entering directory '/mnt/media/d1/ports/devel/libgit2-glib/work/libgit2-glib-0.0.24/libgit2-glib'
  GEN      ggit-enum-types.c
/usr/local/bin/glib-mkenums: ggit-types.h:967: Failed to parse `	                                              GGIT_STATUS_OPTION_INCLUDE_UNTRACKED | '
/usr/local/bin/glib-mkenums: ggit-types.h:1063: Failed to parse `	                                             GGIT_DIFF_BREAK_REWRITES), '
  GEN      ggit-enum-types.h
/usr/local/bin/glib-mkenums: ggit-types.h:967: Failed to parse `	                                              GGIT_STATUS_OPTION_INCLUDE_UNTRACKED | '
/usr/local/bin/glib-mkenums: ggit-types.h:1063: Failed to parse `	                                             GGIT_DIFF_BREAK_REWRITES), '
gmake  all-am
"""

And MAKE_JOBS_UNSAFE is not needed there.
Comment 4 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2015-01-15 10:22:57 UTC 
That's funny because in my tests those parsing error blocked successfull installation, and now it's not. But I'd fix them anyway.
Comment 5 commit-hook freebsd_committer freebsd_triage 2015-01-15 12:22:47 UTC 
A commit references this bug:

Author: amdmi3
Date: Thu Jan 15 12:21:58 UTC 2015
New revision: 377086
URL: https://svnweb.freebsd.org/changeset/ports/377086

Log:
  - Fix glib-mkenums warnings (which may lead to errors)
  - Remove MAKE_JOBS_UNSAFE
  - Sort plist

  PR:		196663
  Submitted by:	rm@FreeBSD.org
  Approved by:	kwm

Changes:
  head/devel/libgit2-glib/Makefile
  head/devel/libgit2-glib/files/
  head/devel/libgit2-glib/files/patch-libgit2-glib__ggit-types.h
  head/devel/libgit2-glib/pkg-plist