Bug 196679 - [patch] x11-wm/fvwm2: Fix compilation error related to gtk12 and clang
Summary: [patch] x11-wm/fvwm2: Fix compilation error related to gtk12 and clang
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Cy Schubert
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-13 13:01 UTC by WATANABE Kazuhiro
Modified: 2015-01-14 02:56 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (cy)

Attachments
A patch for x11-wm/fvwm2. (421 bytes, patch)
2015-01-13 13:01 UTC, WATANABE Kazuhiro 		no flags Details | Diff
Build log on 10.1-RELEASE without x11-toolkits/gtk12. (286.93 KB, text/plain)
2015-01-13 13:03 UTC, WATANABE Kazuhiro 		no flags Details
Build error log on 10.1-RELEASE with x11-toolkits/gtk12. (163.62 KB, text/plain)
2015-01-13 13:04 UTC, WATANABE Kazuhiro 		no flags Details
Build log on 10.1-RELEASE with x11-toolkits/gtk12 and the patch. (286.63 KB, text/plain)
2015-01-13 13:06 UTC, WATANABE Kazuhiro 		no flags Details
poudriere testport log with the patch (10.1-RELEASE amd64) (304.04 KB, text/x-log)
2015-01-13 13:08 UTC, WATANABE Kazuhiro 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description WATANABE Kazuhiro 2015-01-13 13:01:08 UTC 
Created attachment 151552 [details]
A patch for x11-wm/fvwm2.

The previous version of x11-wm/fvwm2 had IMLIB option [1], and the option was
disabled by default.  If the option was disabled, added "--disable-gtk" to
the CONFIGURE_ARGS variable like this:

| .if ${PORT_OPTIONS:MIMLIB}     
| USE_GNOME+=     imlib          
| .else          
| CONFIGURE_ARGS+=--disable-gtk          
| .endif         

...and the FvwmGtk module was not compiled (it requires GTK) and disabled
in pkg-plist.

But the latest x11-wm/fvwm2 doesn't specify "--disable-gtk" anywhere.
So if x11-toolkits/gtk12 has been installed to the system, the configure script
detects the library automatically and tries to compile FvwmGtk which is not
listed in pkg-plist.

Unfortunately FvwmGtk cannot be compiled with clang and causes a compilation
error.  To fix the problem, add a missing "--disable-gtk" argument to the
CONFIGURE_ARGS variable.

# If we really want to compile FvwmGtk with clang, at least we have to add
# "USE_CSTD=gnu89" to Makefile [2].

[1] http://svnweb.freebsd.org/ports/head/x11-wm/fvwm2/Makefile?view=log#rev375573
[2] https://lists.freebsd.org/pipermail/freebsd-ports/2014-December/thread.html#97303
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2015-01-13 13:01:08 UTC 
Auto-assigned to maintainer cy@FreeBSD.org
Comment 2 WATANABE Kazuhiro 2015-01-13 13:03:26 UTC 
Created attachment 151553 [details]
Build log on 10.1-RELEASE without x11-toolkits/gtk12.
Comment 3 WATANABE Kazuhiro 2015-01-13 13:04:55 UTC 
Created attachment 151554 [details]
Build error log on 10.1-RELEASE with x11-toolkits/gtk12.
Comment 4 WATANABE Kazuhiro 2015-01-13 13:06:23 UTC 
Created attachment 151555 [details]
Build log on 10.1-RELEASE with x11-toolkits/gtk12 and the patch.
Comment 5 WATANABE Kazuhiro 2015-01-13 13:08:33 UTC 
Created attachment 151556 [details]
poudriere testport log with the patch (10.1-RELEASE amd64)
Comment 6 commit-hook freebsd_committer freebsd_triage 2015-01-14 02:54:43 UTC 
A commit references this bug:

Author: cy
Date: Wed Jan 14 02:53:53 UTC 2015
New revision: 376992
URL: https://svnweb.freebsd.org/changeset/ports/376992

Log:
  Fix gtk12/clang compile error.

  PR:		196679
  Submitted by:	WATANABE Kazuhiro <CQG00620@nifty.ne.jp>
  Broken by:	r375573

Changes:
  head/x11-wm/fvwm2/Makefile
Comment 7 Cy Schubert freebsd_committer freebsd_triage 2015-01-14 02:56:13 UTC 
Broken by r375573. Committed and fixed. Thanks.