Created attachment 151598 [details] patch file First the port would fail with problems of wrong libstdc++.so for libwebkitgtk-1.0.so. But newer gcc had problems precompiling header files.
Maintainer CC'd
(In reply to Bugzilla Automation from comment #1) Just a note to let you know I'm aware of this pr. But it's late now. So I'll not be examining it till probably tomorrow. :) --Chris
(In reply to Lawrence Chen from comment #0) While I don't see any issue with the patch per se; I'm not sure what you are implying the problem with wxgtk30 is. Are you saying that wxgtk30 doesn't co-exist with wxgtk20? Are you saying wxgtk30 doesn't build on FreeBSD versions greater than 10? Can you please elaborate on what the problem actually is with wxgtk30, and how I would know it doesn't affect only you? This is the first I've heard of any issue with wxgtk30. Thank you for all your time, and consideration. --Chris
The LIB_DEPENDS for libwebkitgtk-1.0.so:${PORTSDIR}/www/webkit-gtk2 was updated to USES compiler:c++11-lib, which causes problems for ports that depend on it. Other ports affected by this change had gotten patched, I based the patch to this port on those. I submitted 3 PRs for ports that remained affected for me, each slightly different depending on how the change the compiler impacted things. At first there were 6 or 7 ports affected, but by the time I figured out how to get this one working again, there were only 2 other ports failing. Makes me wonder if I'm the only person using those two applications. In almost all the other ports, the patch was described as fixing build on 8. But, I'm on 9.3-RELEASE. The CONFIGURE_ARGS line is the part of patch that is specific to this port. The other lines were copied from what was done to fix another port. The combination of bugzilla being down and the same treatment to webkit-gtk3 led quite a lot of PRs all at once ;)
(In reply to Lawrence Chen from comment #4) Thanks for the thoughtful reply, Lawrence. It all makes perfect sense. Thank you also, for all the time (and trouble) to do all this. Patch approved! :) FWIW I'm on 11. --Chris
Created attachment 151742 [details] x11-toolkits/wxgtk30 fixes issue indicated in pr(1) This is an svn diff incorporating the work by Lawrence Chen, who discovered an issue related to webkit-gtk2. Thanks to Lawrence Chen, for reporting, and submitting a solution. @committers; I approve this patch. Please commit it. :) --Chris
A commit references this bug: Author: amdmi3 Date: Sat Jan 24 02:00:11 UTC 2015 New revision: 377776 URL: https://svnweb.freebsd.org/changeset/ports/377776 Log: - Fix library on < 10.x after webkit-gtk2 update Some dependent ports may need USES=compiler:c++11-lib as well PR: 196703 [1], 197031 [2] Submitted by: beastie@tardisi.com [1], amdmi3 [2] Approved by: portmaster@bsdforge.com (maintainer) MFH: 2015Q1 Changes: head/x11-toolkits/wxgtk30/Makefile
A commit references this bug: Author: amdmi3 Date: Tue Feb 3 20:12:56 UTC 2015 New revision: 378372 URL: https://svnweb.freebsd.org/changeset/ports/378372 Log: MFH: r377776 - Fix library on < 10.x after webkit-gtk2 update Some dependent ports may need USES=compiler:c++11-lib as well PR: 196703 [1], 197031 [2] Submitted by: beastie@tardisi.com [1], amdmi3 [2] Approved by: portmaster@bsdforge.com (maintainer) Approved by: portmgr (antoine) Changes: _U branches/2015Q1/ branches/2015Q1/x11-toolkits/wxgtk30/Makefile