Bug 196788 - Log rotation non-existent for opensm; opensm expects SIGUSR1, not SIGHUP
Summary: Log rotation non-existent for opensm; opensm expects SIGUSR1, not SIGHUP
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: Enji Cooper
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-15 23:28 UTC by Enji Cooper
Modified: 2015-07-08 19:11 UTC (History)
2 users (show)

See Also:
ngie: mfc-stable10+
ngie: mfc-stable9+
ngie: mfc-stable8-


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Enji Cooper freebsd_committer freebsd_triage 2015-01-15 23:28:47 UTC
/var/log/opensm.log never rotates because it's not integrated into newsyslogd.
This proposed commit might fix that, but it needs to be fully reviewed/vetted:
https://github.com/yaneurabeya/freebsd/commit/2fbaa2a979cb9883c2de735ae8f5795fe26aefe7
Comment 1 Hans Petter Selasky freebsd_committer freebsd_triage 2015-01-16 09:25:20 UTC
Don't forget to add "MFC after" to the commit.
syslogd is a bit outside my area and I think someone else needs to comment on that.

--HPS
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-01-22 23:51:26 UTC
A commit references this bug:

Author: ngie
Date: Thu Jan 22 23:50:49 UTC 2015
New revision: 277541
URL: https://svnweb.freebsd.org/changeset/base/277541

Log:
  Add sample log rotation support for opensm

  Up to 7 archives of the log will be kept (just for consistency with the other
  log rotation rules)

  PR: 196788
  MFC after: 1 week
  Reviewed by: hselasky
  Sponsored by: EMC / Isilon Storage Division

Changes:
  head/etc/Makefile
  head/etc/newsyslog.conf.d/
  head/etc/newsyslog.conf.d/Makefile
  head/etc/newsyslog.conf.d/opensm.conf
Comment 3 commit-hook freebsd_committer freebsd_triage 2015-02-02 09:25:23 UTC
A commit references this bug:

Author: ngie
Date: Mon Feb  2 09:24:41 UTC 2015
New revision: 278067
URL: https://svnweb.freebsd.org/changeset/base/278067

Log:
  MFC r277541:

  r277541:

    Add sample log rotation support for opensm

    Up to 7 archives of the log will be kept (just for consistency with the other
    log rotation rules)

    PR: 196788
    Reviewed by: hselasky
    Sponsored by: EMC / Isilon Storage Division

Changes:
_U  stable/10/
  stable/10/etc/Makefile
  stable/10/etc/newsyslog.conf.d/
  stable/10/etc/newsyslog.conf.d/Makefile
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-02-02 10:01:27 UTC
A commit references this bug:

Author: ngie
Date: Mon Feb  2 10:00:46 UTC 2015
New revision: 278069
URL: https://svnweb.freebsd.org/changeset/base/278069

Log:
  MFC r278067:

  r278067:

    MFC r277541:

    r277541:

      Add sample log rotation support for opensm

      Up to 7 archives of the log will be kept (just for consistency with the other
      log rotation rules)

      PR: 196788
      Reviewed by: hselasky
      Sponsored by: EMC / Isilon Storage Division

Changes:
_U  stable/9/
_U  stable/9/etc/
  stable/9/etc/Makefile
  stable/9/etc/newsyslog.conf.d/
Comment 5 Glen Barber freebsd_committer freebsd_triage 2015-07-08 18:32:10 UTC
To originators/assignees of this PR:

A commit to the tree references this PR, however the PR is still in a non-closed state.

Please review this PR and close as appropriate, or if closing the PR requires a merge to stable/10, please let re@ know as soon as possible.

Thank you.

Glen