Bug 196790 - [patch] Fix zroot + GELI support in bsdinstall
Summary: [patch] Fix zroot + GELI support in bsdinstall
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: Steven Hartland
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-16 00:53 UTC by Michael Gmelin
Modified: 2015-01-18 18:34 UTC (History)
1 user (show)

See Also:

Attachments
Fix GELI support in bsdinstall/zfsboot (465 bytes, patch)
2015-01-16 00:53 UTC, Michael Gmelin 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Gmelin freebsd_committer freebsd_triage 2015-01-16 00:53:31 UTC 
Created attachment 151716 [details]
Fix GELI support in bsdinstall/zfsboot

Apparently GELI support was always broken when not using 4k blocks in bsdinstall.

The change from gnop to setting ashift directly in r276027 broke GELI completely as a side effect. The fix is as trivial as the problem.
Comment 1 Allan Jude freebsd_committer freebsd_triage 2015-01-16 01:28:00 UTC 
Patch pushed for review: https://reviews.freebsd.org/D566
Comment 2 Steven Hartland freebsd_committer freebsd_triage 2015-01-16 09:45:58 UTC 
Ahh, well at least we found the original issue even if it did break for a while ;-)

Thanks for fixing.
Comment 3 Michael Gmelin freebsd_committer freebsd_triage 2015-01-18 18:13:54 UTC 
As I have only a commit bit for ports, could you commit the patch?
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-01-18 18:26:11 UTC 
A commit references this bug:

Author: smh
Date: Sun Jan 18 18:25:13 UTC 2015
New revision: 277333
URL: https://svnweb.freebsd.org/changeset/base/277333

Log:
  Fix bsdinstall when working with geli boot disks

  PR:		196790
  Differential Revision:	https://reviews.freebsd.org/D566
  Submitted by:	Michael Gmelin <grembo@FreeBSD.org>
  MFC after:	2 weeks
  Sponsored by:	Multiplay

Changes:
  head/usr.sbin/bsdinstall/scripts/zfsboot