Bug 196793 - osmtest --version causes an assertion failure instead of printing out a usage message
Summary: osmtest --version causes an assertion failure instead of printing out a usage...
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: tests (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: Enji Cooper
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-16 03:18 UTC by Enji Cooper
Modified: 2015-01-24 03:05 UTC (History)
2 users (show)

See Also:
ngie: mfc-stable10+
ngie: mfc-stable9+

Attachments
patch (441 bytes, patch)
2015-01-16 03:18 UTC, Enji Cooper 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enji Cooper freebsd_committer freebsd_triage 2015-01-16 03:18:35 UTC 
Created attachment 151719 [details]
patch

This is not very user friendly behavior:

$ /usr/tests/usr.bin/opensm/osmtest --version
Command Line Arguments
osmtest: unrecognized option `--version'
Abort trap (core dumped)

The attached patch fixes that.

Sponsored by: EMC / Isilon Storage Division
Comment 1 Enji Cooper freebsd_committer freebsd_triage 2015-01-16 03:19:29 UTC 
I'll commit this change to head soon.
Comment 2 Hans Petter Selasky freebsd_committer freebsd_triage 2015-01-16 09:22:35 UTC 
Don't forget to add "MFC after". Patch looks good.

--HPS
Comment 3 commit-hook freebsd_committer freebsd_triage 2015-01-16 21:13:29 UTC 
A commit references this bug:

Author: ngie
Date: Fri Jan 16 21:12:37 UTC 2015
New revision: 277272
URL: https://svnweb.freebsd.org/changeset/base/277272

Log:
  Don't call abort on usage errors; print out the usage message instead

  PR: 196793
  MFC after: 3 days
  Sponsored by: EMC / Isilon Storage Division

Changes:
  head/contrib/ofed/management/opensm/osmtest/main.c
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-01-19 07:15:27 UTC 
A commit references this bug:

Author: ngie
Date: Mon Jan 19 07:14:37 UTC 2015
New revision: 277366
URL: https://svnweb.freebsd.org/changeset/base/277366

Log:
  MFC r277272:

  r277272 (by ngie):

    Don't call abort on usage errors; print out the usage message instead

    PR: 196793
    Sponsored by: EMC / Isilon Storage Division

Changes:
_U  projects/stable-10-opts-mk/
  projects/stable-10-opts-mk/contrib/ofed/management/opensm/osmtest/main.c
Comment 5 commit-hook freebsd_committer freebsd_triage 2015-01-19 07:20:28 UTC 
A commit references this bug:

Author: ngie
Date: Mon Jan 19 07:19:57 UTC 2015
New revision: 277369
URL: https://svnweb.freebsd.org/changeset/base/277369

Log:
  MFC r277272:

  r277272 (by ngie):

    Don't call abort on usage errors; print out the usage message instead

    PR: 196793
    Sponsored by: EMC / Isilon Storage Division

Changes:
_U  stable/10/
  stable/10/contrib/ofed/management/opensm/osmtest/main.c
Comment 6 commit-hook freebsd_committer freebsd_triage 2015-01-24 03:04:47 UTC 
A commit references this bug:

Author: ngie
Date: Sat Jan 24 03:04:09 UTC 2015
New revision: 277636
URL: https://svnweb.freebsd.org/changeset/base/277636

Log:
  MFC r277272:

    Don't call abort on usage errors; print out the usage message instead

    PR: 196793
    Sponsored by: EMC / Isilon Storage Division

Changes:
_U  stable/9/
_U  stable/9/contrib/
  stable/9/contrib/ofed/management/opensm/osmtest/main.c