Bug 196806 - print/cups-base: build fails if any option other than MDNSRESPONDER is selected
Summary: print/cups-base: build fails if any option other than MDNSRESPONDER is selected
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tijl Coosemans
URL:
Keywords:
Depends on: 207746
Blocks:
  Show dependency treegraph
 
Reported: 2015-01-16 18:31 UTC by Gary
Modified: 2016-03-11 14:21 UTC (History)
3 users (show)

See Also:


Attachments
poudriere logfile with Avahi selcted (44.34 KB, text/plain)
2015-01-16 18:31 UTC, Gary
no flags Details
poudriere logfile with neither avahi nor mdnsresponder selected (39.86 KB, text/plain)
2015-01-16 18:32 UTC, Gary
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gary 2015-01-16 18:31:25 UTC
cups-base seems not to build unless you select MDNSRESPONDER
Comment 1 Gary 2015-01-16 18:31:58 UTC
Created attachment 151744 [details]
poudriere logfile with Avahi selcted
Comment 2 Gary 2015-01-16 18:32:26 UTC
Created attachment 151745 [details]
poudriere logfile with neither avahi nor mdnsresponder selected
Comment 3 Tobias Kortkamp freebsd_committer freebsd_triage 2016-02-12 15:16:41 UTC
I did some investigating on this.  The problem still exists and seems to surface when print/cups-base and print/cups-client have different options selected for Zeroconf support.  For example if cups-base uses AVAHI and cups-client uses MDNSRESPONDER compilation will fail.  I'm unsure how this can be fixed.  The split of cups into cups-base, cups-client, cups-image makes this harder than it has to be.
Comment 4 Tobias Kortkamp freebsd_committer freebsd_triage 2016-02-13 17:38:28 UTC
Also see bug #203053.
Comment 5 Chris Hutchinson 2016-02-17 20:04:16 UTC
(In reply to Tobias Kortkamp from comment #3)
> I did some investigating on this.  The problem still exists and seems to
> surface when print/cups-base and print/cups-client have different options
> selected for Zeroconf support.  For example if cups-base uses AVAHI and
> cups-client uses MDNSRESPONDER compilation will fail.  I'm unsure how this
> can be fixed.  The split of cups into cups-base, cups-client, cups-image
> makes this harder than it has to be.

Shouldn't all the cups-* be children of print/cups-base ?
eg; MASTERDIR?=	${.CURDIR}/../cups-base

Where name/connection resolution options are *only* possible
via it's master/parent: print/cups-base ?

I'm sure that this route would prevent conflicting (M)OPTION
choices. No?

Just my 0.2ยข on the matter. :)

--Chris
Comment 6 Tobias Kortkamp freebsd_committer freebsd_triage 2016-02-17 20:38:56 UTC
(In reply to Chris Hutchinson from comment #5)
They all have MASTERDIR set.  Here's what I tried:

1. I've rmconfig'ed both cups-client and cups-base.
2. Then I enabled the AVAHI option in cups-base
3. Now cups-client and cups-base have conflicting options selected.
   Is MASTERDIR supposed to enable some kind of magic that prevents this from
   happening?  What I would expect is for both of them to have AVAHI=on now
   (i.e. that cups-base dictates the options for cups-client).  I also would
   expect make -C cups-client config to tell me that I need to configure
   cups-base instead and not present the option dialog at all.

$ make -C /usr/ports/print/cups-client showconfig
===> The following configuration options are available for cups-client-2.0.3_2:
====> Zeroconf support: you can only select none or one of them
     AVAHI=off: Zeroconf support via Avahi
     MDNSRESPONDER=on: Zeroconf support via mDNSResponder
===> Use 'make config' to modify these settings

$ make -C /usr/ports/print/cups-base showconfig
===> The following configuration options are available for cups-base-2.0.3_6:
[...]
====> Zeroconf support: you can only select none or one of them
     AVAHI=on: Zeroconf support via Avahi
     MDNSRESPONDER=off: Zeroconf support via mDNSResponder
===> Use 'make config' to modify these settings
Comment 7 Chris Hutchinson 2016-02-17 22:24:21 UTC
(In reply to Tobias Kortkamp from comment #6)
> (In reply to Chris Hutchinson from comment #5)
> They all have MASTERDIR set.  Here's what I tried:
> 
> 1. I've rmconfig'ed both cups-client and cups-base.
> 2. Then I enabled the AVAHI option in cups-base
> 3. Now cups-client and cups-base have conflicting options selected.
>    Is MASTERDIR supposed to enable some kind of magic that prevents this from
>    happening?

Well. That's the (intended?) logic from my experience.
While I do have a couple of 9-STABLE boxes; I'm writing this
from a -CURRENT (11) box. So I'm using that ports tree for
reference(s). I only mention that, as I notice you appear to be
talking about 9.(3?) given your attached log(s). I see there's an
entry in UPDATING about cups-client / cups-image, but it's dated
20140331. So I can't imagine it applies to you. Looking at the
print/cups-base/Makefile nothing jumps out at me to lead me to
think it would generate more than *one* set of [*dns*] options.

You don't have anything in your make.conf(5) that might pollute
your environment, do you?

Just a thought.

--Chris
Comment 8 Tijl Coosemans freebsd_committer freebsd_triage 2016-03-11 14:21:47 UTC
Since ports r410825 the MDNSRESPONDER option has been removed so this should no longer be a problem.