Bug 196840 - audio/filter_audio: fix build
Summary: audio/filter_audio: fix build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thierry Thomas
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-18 16:27 UTC by Igor Ostapenko
Modified: 2015-02-08 22:40 UTC (History)
2 users (show)

See Also:
thierry: maintainer-feedback+

Attachments
filter_audio-0.1.diff (985 bytes, patch)
2015-01-18 16:27 UTC, Igor Ostapenko 		no flags Details | Diff
Patch updating the port's upstream revision, where OP problem is fixed (1.18 KB, patch)
2015-01-19 01:13 UTC, Yuri Victorovich 		yuri: maintainer-approval+
Details | Diff
poudriere log for filter_audio (16.10 KB, text/plain)
2015-01-19 01:17 UTC, Yuri Victorovich 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Igor Ostapenko freebsd_committer freebsd_triage 2015-01-18 16:27:49 UTC 
Created attachment 151790 [details]
filter_audio-0.1.diff

I think there are at least two points:

1. I noticed it's not buildable on previous OS versions which have old "install" without "-D" option, e.g. it may end up like this:

install -Dm755 libfilteraudio.so /usr/ports/audio/filter_audio/work/stage//usr/local/lib/libfilteraudio.so
install: illegal option -- D
usage: install [-bCcMpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
               [-o owner] file1 file2
       install [-bCcMpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
               [-o owner] file1 ... fileN directory
       install -d [-v] [-g group] [-m mode] [-o owner] directory ...
Makefile:19: recipe for target 'install' failed
gmake: *** [install] Error 64
*** [do-install] Error code 2

Stop in /usr/ports/audio/filter_audio.

2. It looks like meaning of "-D" option in new "install" differs from "-D" of non-BSD "install" and as a result "-m" option doesn't take effect. Checked on 10.0.

See patch example.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2015-01-18 16:27:49 UTC 
Maintainer CC'd
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2015-01-18 19:35:34 UTC 
Change approved. Thanks!

Igor, I think you should also file the bug report for this in the upstream github project, because other OSes can also benefit from the change.
Comment 3 Igor Ostapenko freebsd_committer freebsd_triage 2015-01-18 22:17:35 UTC 
Pull request sent. We can wait for a while to possibly go w/o such patch. Or the port can be updated again later.
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2015-01-18 23:06:04 UTC 
They accepted your PR, I will add the patch for the port shortly.
Comment 5 Yuri Victorovich freebsd_committer freebsd_triage 2015-01-19 01:13:30 UTC 
Created attachment 151814 [details]
Patch updating the port's upstream revision, where OP problem is fixed
Comment 6 Yuri Victorovich freebsd_committer freebsd_triage 2015-01-19 01:17:34 UTC 
Created attachment 151815 [details]
poudriere log for filter_audio

Attachment filter_audio-0.1.diff is made obsolete by the subsequent port update patch.

This PR should be made PATCH-READY.

Thanks to Igor Ostapenko for noticing and resolving the problem!
Comment 7 Yuri Victorovich freebsd_committer freebsd_triage 2015-02-08 21:38:42 UTC 
This should be set to "patch-ready".
Comment 8 commit-hook freebsd_committer freebsd_triage 2015-02-08 22:39:57 UTC 
A commit references this bug:

Author: thierry
Date: Sun Feb  8 22:39:11 UTC 2015
New revision: 378698
URL: https://svnweb.freebsd.org/changeset/ports/378698

Log:
  Upgrade to a newer snapshot, including a fix for an installation problem.

  PR:		ports/196840
  Submitted by:	 Igor Ostapenko
  Approved by:	yuri (at) rawbw.com (maintainer)

Changes:
  head/audio/filter_audio/Makefile
  head/audio/filter_audio/distinfo
Comment 9 Thierry Thomas freebsd_committer freebsd_triage 2015-02-08 22:40:44 UTC 
Committed, thanks!

Note: since the distfiles have the same name, I added a DIST_SUBDIR to avoid collision.