Bug 196932 - graphics/xpdf: pdftoppm now depends on X
Summary: graphics/xpdf: pdftoppm now depends on X
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Cy Schubert
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-20 14:40 UTC by Robert Schulze
Modified: 2015-01-20 19:15 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (cy)

Attachments
make pdftoppm depend on X11 (1.90 KB, patch)
2015-01-20 14:40 UTC, Robert Schulze 		no flags Details | Diff
2nd patch, regarding the manpage of pdftoppm in pkg-plist (2.21 KB, patch)
2015-01-20 14:46 UTC, Robert Schulze 		no flags Details | Diff
Build pdftoppm in all-no-x target. (990 bytes, patch)
2015-01-20 16:31 UTC, Cy Schubert 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Schulze 2015-01-20 14:40:13 UTC 
Created attachment 151904 [details]
make pdftoppm depend on X11

Trying to build graphics/xpdf without X11 results in the following error:

install  -s -o root -g wheel -m 555 xpdf/pdftoppm /usr/ports/graphics/xpdf/work/stage/usr/local/libexec/xpdf/pdftoppm
install: xpdf/pdftoppm: No such file or directory
Makefile:85: recipe for target 'install' failed
gmake[2]: *** [install] Error 71
gmake[2]: Leaving directory '/usr/ports/graphics/xpdf/work/xpdf-3.04'
*** Error code 2

Stop.
make[1]: stopped in /usr/ports/graphics/xpdf
*** Error code 1

Stop.
make: stopped in /usr/ports/graphics/xpdf

Since pdftoppm depends on X, it should only be build and installed when X11 support is enabled. The attached patch tries to address that. Maybe files/patch-Makefile.in could be omitted completely since it is a noop now.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2015-01-20 14:40:13 UTC 
Auto-assigned to maintainer cy@FreeBSD.org
Comment 2 Robert Schulze 2015-01-20 14:46:41 UTC 
Created attachment 151905 [details]
2nd patch, regarding the manpage of pdftoppm in pkg-plist
Comment 3 Cy Schubert freebsd_committer freebsd_triage 2015-01-20 16:31:45 UTC 
Created attachment 151909 [details]
Build pdftoppm in all-no-x target.

I'll commit this patch at noon (PST) today.
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-01-20 19:14:34 UTC 
A commit references this bug:

Author: cy
Date: Tue Jan 20 19:14:07 UTC 2015
New revision: 377531
URL: https://svnweb.freebsd.org/changeset/ports/377531

Log:
  pdftoppm was not built in all-no-x target. Fix this.

  PR:		PR/196932

Changes:
  head/graphics/xpdf/Makefile
  head/graphics/xpdf/files/patch-xpdf__Makefile.in
Comment 5 Cy Schubert freebsd_committer freebsd_triage 2015-01-20 19:15:42 UTC 
Fixed by r377531.