Bug 197162 - [NEW PORT] net-mgmt/dhcp_probe: Detect DHCP servers on network
Summary: [NEW PORT] net-mgmt/dhcp_probe: Detect DHCP servers on network
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thomas Zander
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2015-01-29 02:26 UTC by Kevin Hung
Modified: 2015-03-07 18:38 UTC (History)
2 users (show)

See Also:


Attachments
dhcp_probe.shar (22.24 KB, text/plain)
2015-01-29 02:26 UTC, Kevin Hung
no flags Details
new shar (22.98 KB, text/plain)
2015-02-07 15:35 UTC, Kevin Hung
no flags Details
poudriere log - 10.1 amd64 (32.11 KB, text/plain)
2015-02-07 15:38 UTC, Kevin Hung
no flags Details
poudriere log - 9.3 amd64 (24.34 KB, text/plain)
2015-02-07 15:38 UTC, Kevin Hung
no flags Details
poudriere log - 8.4 amd64 (31.89 KB, text/plain)
2015-02-07 15:39 UTC, Kevin Hung
no flags Details
dhcp_probe.shar (23.14 KB, text/plain)
2015-02-22 20:17 UTC, Kevin Hung
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Hung 2015-01-29 02:26:04 UTC
Created attachment 152324 [details]
dhcp_probe.shar

dhcp_probe attempts to detect DHCP and BootP servers in a directly-attached Ethernet network. This can be launched as a standalone program or as a service. It provides the ability to call an external program on detecting an unexpected server.

Website: https://www.net.princeton.edu/software/dhcp_probe/
Comment 1 Kevin Hung 2015-02-07 15:35:52 UTC
Created attachment 152672 [details]
new shar
Comment 2 Kevin Hung 2015-02-07 15:38:10 UTC
Created attachment 152673 [details]
poudriere log - 10.1 amd64
Comment 3 Kevin Hung 2015-02-07 15:38:40 UTC
Created attachment 152674 [details]
poudriere log - 9.3 amd64
Comment 4 Kevin Hung 2015-02-07 15:39:02 UTC
Created attachment 152675 [details]
poudriere log - 8.4 amd64
Comment 5 Kevin Hung 2015-02-07 15:40:31 UTC
New shar and attached poudriere testport logs for 8.4, 9.3, and 10.1 (amd64 only).

Fixed wrong argument order in rc.d script, typo in conf sample, and correct LICENSE order in Makefile.
Comment 6 Kurt Jaeger freebsd_committer freebsd_triage 2015-02-22 18:36:27 UTC
(In reply to khung from comment #5)

I tried to build it using poudriere and it failed with:

=======================<phase: check-sanity   >============================
===>  dhcp_probe-1.3.0 License GPLv2 addl needs confirmation, but BATCH is defined.
*** Error code 1

From what I see, the license is pretty much a combination of GPL2 and BSD3CLAUSE.
Why is a explicit confirmation needed ?
Comment 7 Kevin Hung 2015-02-22 18:59:37 UTC
(In reply to Kurt Jaeger from comment #6)

I'm not familiar with how FreeBSD ports treat licensing. From my understanding, there are additional licenses in the COPYING file in the source that say "redistribution of (binaries|source code) must include the above copyright notice". The file is also available online [1].

If we do not need to show the licenses to the end-user, I can change the Makefile to include auto-accept in LICENSE_PERMS_addl.

[1] https://www.net.princeton.edu/software/dhcp_probe/COPYING.txt
Comment 8 Kurt Jaeger freebsd_committer freebsd_triage 2015-02-22 19:37:11 UTC
"include" means it should be included in the package, probably in the DOCS.
That should be sufficient.
Comment 9 Kevin Hung 2015-02-22 20:17:45 UTC
Created attachment 153335 [details]
dhcp_probe.shar

Updated Makefile to auto-accept additional licenses and copy all license files to the DOCS.
Comment 10 Thomas Zander freebsd_committer freebsd_triage 2015-03-07 08:14:26 UTC
This port always links to libpcap from the base system (even if pcap from ports is installed), so the LIB_DEPENDS on libpcap from ports is not needed.
I would remove this dependency and commit if you approve.
Comment 11 Kevin Hung 2015-03-07 16:50:57 UTC
(In reply to Thomas Zander from comment #10)

Thanks, I agree that LIB_DEPENDS on libpcap is not needed. You can go ahead and make the change unless you prefer that I upload a new shar.
Comment 12 commit-hook freebsd_committer freebsd_triage 2015-03-07 18:33:39 UTC
A commit references this bug:

Author: riggs
Date: Sat Mar  7 18:33:22 UTC 2015
New revision: 380712
URL: https://svnweb.freebsd.org/changeset/ports/380712

Log:
  Initial import of net-mgmt/dhcp_probe, a tool to
  discover DHCP and BootP servers on a network

  PR:		197162
  Submitted by:	khung@nullaxiom.com (maintainer)

Changes:
  head/net-mgmt/Makefile
  head/net-mgmt/dhcp_probe/
  head/net-mgmt/dhcp_probe/Makefile
  head/net-mgmt/dhcp_probe/distinfo
  head/net-mgmt/dhcp_probe/files/
  head/net-mgmt/dhcp_probe/files/dhcp_probe.in
  head/net-mgmt/dhcp_probe/files/patch-Makefile.am
  head/net-mgmt/dhcp_probe/files/patch-extras-dhcp__probe.cf.sample
  head/net-mgmt/dhcp_probe/files/patch-src_bootp.c
  head/net-mgmt/dhcp_probe/files/patch-src_configfile.c
  head/net-mgmt/dhcp_probe/files/patch-src_configfile.h
  head/net-mgmt/dhcp_probe/files/patch-src_daemonize.c
  head/net-mgmt/dhcp_probe/files/patch-src_defs.h
  head/net-mgmt/dhcp_probe/files/patch-src_dhcp__probe.c
  head/net-mgmt/dhcp_probe/files/patch-src_dhcp__probe.h
  head/net-mgmt/dhcp_probe/files/patch-src_get__myeaddr.c
  head/net-mgmt/dhcp_probe/files/patch-src_get__myeaddr.h
  head/net-mgmt/dhcp_probe/files/pkg-message.in
  head/net-mgmt/dhcp_probe/pkg-descr
  head/net-mgmt/dhcp_probe/pkg-plist
Comment 13 Thomas Zander freebsd_committer freebsd_triage 2015-03-07 18:38:11 UTC
(In reply to khung from comment #11)

Nah, no worries, no new shar needed. Committed, thanks!
Enjoy maintaining!