Bug 197258 - [maintainer update] audio/id3mtag: update to 0.79
Summary: [maintainer update] audio/id3mtag: update to 0.79
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-02 00:54 UTC by Marc Schoolderman
Modified: 2015-02-02 18:43 UTC (History)
1 user (show)

See Also:


Attachments
diff file for audio/id3mtag (1.84 KB, patch)
2015-02-02 00:54 UTC, Marc Schoolderman
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Schoolderman 2015-02-02 00:54:26 UTC
Created attachment 152460 [details]
diff file for audio/id3mtag

New in this version:
+ Simply lists tags if run without options.
+ Processes all already-present tags by default, not just ID3v1.
+ Should be able to handle most ID3v2.4 tags.
+ Now uses iconv to convert between charsets.

Port specific:
+ All URL's have been changed due to the original website going down.
Comment 1 commit-hook freebsd_committer freebsd_triage 2015-02-02 18:40:16 UTC
A commit references this bug:

Author: amdmi3
Date: Mon Feb  2 18:39:39 UTC 2015
New revision: 378315
URL: https://svnweb.freebsd.org/changeset/ports/378315

Log:
  - Update to 0.79

  PR:		197258
  Submitted by:	squell@alumina.nl (maintainer)

Changes:
  head/audio/id3mtag/Makefile
  head/audio/id3mtag/distinfo
  head/audio/id3mtag/pkg-descr
Comment 2 Dmitry Marakasov freebsd_committer freebsd_triage 2015-02-02 18:43:39 UTC
Committed with minor change (added LICENSE_FILE).

Since you're the author, I suggest to fix the makefile to not override flags set in environment. This will make building with pre-set environment and from packaging systems easier. In particular, with FreeBSD ports it'll allow to drop MAKE_ARGS.

---
-CC      = cc
-CXX     = c++
-CFLAGS  = $(WARNINGS:%=-W%) -pedantic -g -Os
-CXXFLAGS = $(CFLAGS) -fno-rtti
-LDFLAGS  =
+CC      ?= cc
+CXX     ?= c++
+CFLAGS  += $(WARNINGS:%=-W%) -pedantic -g -Os
+CXXFLAGS += $(WARNINGS:%=-W%) -pedantic -g -Os -fno-rtti
+LDFLAGS  +=
---