Bug 197324 - editors/deforaos-editor: Update to 0.3.0
Summary: editors/deforaos-editor: Update to 0.3.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: John Marino
URL:
Keywords: patch-ready
Depends on:
Blocks:
 
Reported: 2015-02-04 17:05 UTC by olivier
Modified: 2015-02-06 15:07 UTC (History)
1 user (show)

See Also:


Attachments
patch for updating the port (1.63 KB, patch)
2015-02-04 17:05 UTC, olivier
no flags Details | Diff
poudriere testport log file (27.54 KB, text/plain)
2015-02-04 17:06 UTC, olivier
no flags Details
poudriere testport log file (34.13 KB, text/plain)
2015-02-05 10:46 UTC, olivier
no flags Details
new patch for updating the port (1.75 KB, patch)
2015-02-05 12:05 UTC, olivier
no flags Details | Diff
new poudriere testport log file (33.73 KB, text/plain)
2015-02-05 12:06 UTC, olivier
no flags Details
new patch for updating the port (2.18 KB, patch)
2015-02-05 16:39 UTC, olivier
no flags Details | Diff
poudriere testport log file (38.79 KB, text/plain)
2015-02-05 16:39 UTC, olivier
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description olivier 2015-02-04 17:05:45 UTC
Created attachment 152556 [details]
patch for updating the port

Here is a maintainer update for upgrading deforaos-editor to 0.3.0
Comment 1 olivier 2015-02-04 17:06:06 UTC
Created attachment 152557 [details]
poudriere testport log file
Comment 2 John Marino freebsd_committer freebsd_triage 2015-02-05 09:50:40 UTC
hmm, the poudriere log doesn't seen to have the stage-qa check.  Did you set the "-t" with "poudriere bulk"?  Or alternative use "poudriere testport" to generate the log?
Comment 3 olivier 2015-02-05 10:46:58 UTC
Created attachment 152575 [details]
poudriere testport log file

Here is the good "poudriere testport" log file
Comment 4 John Marino freebsd_committer freebsd_triage 2015-02-05 10:48:58 UTC
okay, so it appears the binaries need to be stripped per that log:

Warning: 'bin/filter' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'bin/editor' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Comment 5 olivier 2015-02-05 12:05:44 UTC
Created attachment 152578 [details]
new patch for updating the port

Add the missing STRIP
Comment 6 olivier 2015-02-05 12:06:04 UTC
Created attachment 152579 [details]
new poudriere testport log file
Comment 7 John Marino freebsd_committer freebsd_triage 2015-02-05 12:10:22 UTC
as in the other PR, please change:
	@${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/editor
	@${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/filter

to

	${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/editor
	${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/filter

or even better:
	${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/editor \
		${STAGEDIR}${PREFIX}/bin/filter


Installation command *cannot* be masked.
Comment 8 olivier 2015-02-05 16:39:04 UTC
Created attachment 152590 [details]
new patch for updating the port

fix the port and re-enabling doc (original author of this software prefer to bring the doc with)
Comment 9 olivier 2015-02-05 16:39:28 UTC
Created attachment 152591 [details]
poudriere testport log file
Comment 10 John Marino freebsd_committer freebsd_triage 2015-02-05 16:44:23 UTC
thanks, this looks good.
I'm promoting the PR to "patch-ready" pool for final review and commit.
Comment 11 John Marino freebsd_committer freebsd_triage 2015-02-06 15:07:27 UTC
Author: marino
Date: Fri Feb  6 15:03:38 2015
New Revision: 378542
URL: https://svnweb.freebsd.org/changeset/ports/378542
QAT: https://qat.redports.org/buildarchive/r378542/

Log:
  editors/deforaos-editor: Upgrade version 0.2.1 => 0.3.0
  
  PR:		152590
  Submitted by:	maintainer (Olivier Cochard)

Modified:
  head/editors/deforaos-editor/Makefile
  head/editors/deforaos-editor/distinfo
  head/editors/deforaos-editor/pkg-plist



(I wrote attachment ID instead of PR ID so it didn't automatically log the commit).   Closing PR, thanks.