on the libcli port, the Makefile was patched, specifically this line -CFLAGS += $(DEBUG) $(OPTIM) -Wall -std=c99 -pedantic -Wformat-security -Wno-format-zero-length -Werror -Wwrite-strings -Wformat -fdiagnostics-show-option -Wextra -Wsign-compare -Wcast-align -Wno-unused-parameter +CFLAGS += -Wall -Wformat-security -Wno-format-zero-length -Werror -Wwrite-strings -Wformat -fdiagnostics-show-option -Wextra -Wsign-compare -Wcast-align -Wno-unused-parameter The "-Werror" flag should have been removed as well. ON DragonFly: cc -pipe -O2 -fno-strict-aliasing -Wall -Wformat-security -Wno-format-zero-length -Werror -Wwrite-strings -Wformat -fdiagnostics-show-option -Wextra -Wsign-compare -Wcast-align -Wno-unused-parameter -fPIC -o clitest.o -c clitest.c In file included from libcli.c:13:0: /usr/include/malloc.h:2:2: error: #warning "this file includes <malloc.h> which is deprecated, use <stdlib.h> instead" [-Werror=cpp] cc1: all warnings being treated as errors Makefile:32: recipe for target 'libcli.o' failed portmgr has issued a blanket to remove Werror as a rule (fyi) because in almost every cause the warning should not prevent the build from succeeding. Can the patch be updated to remove -Werror too?
Auto-assigned to maintainer tj@FreeBSD.org
Simple as it is, the PR timed out. I'll take it over and just do it.
A commit references this bug: Author: marino Date: Wed Feb 18 08:51:46 UTC 2015 New revision: 379202 URL: https://svnweb.freebsd.org/changeset/ports/379202 Log: devel/libcli: Disable -Werror to restore build on DragonFly This port includes <malloc.h> which generates a warning on DF. PR: 197330 Submitted by: marino@ Approved by: maintainer timeout (tj@) Changes: head/devel/libcli/files/patch-Makefile