Bug 197332 - sysutils/pefs-kmod: builds on ARMv6 (Poudriere Powered)
Summary: sysutils/pefs-kmod: builds on ARMv6 (Poudriere Powered)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm Any
: --- Affects Many People
Assignee: Gleb Kurtsou
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-04 20:46 UTC by Vinícius Zavam
Modified: 2015-02-07 23:48 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (gleb)


Attachments
pefs-kmod-2014.03.31.log (50.77 KB, text/x-log)
2015-02-04 20:46 UTC, Vinícius Zavam
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Vinícius Zavam freebsd_committer freebsd_triage 2015-02-04 20:46:57 UTC
Created attachment 152564 [details]
pefs-kmod-2014.03.31.log

% pwd
/panzer/freebsd/ports/sysutils/pefs-kmod
% svn diff
Index: Makefile
===================================================================
--- Makefile    (revision 378406)
+++ Makefile    (working copy)
@@ -15,7 +15,7 @@
 MAKE_ENV=      BINDIR="${PREFIX}/sbin" MANDIR="${MANPREFIX}/man/man" \
                NO_MANCOMPRESS=
 
-ONLY_FOR_ARCHS=        i386 amd64      # not tested on other archs
+# ONLY_FOR_ARCHS=      i386 amd64      # not tested on other archs
 
 USES=          kmod uidfix
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2015-02-04 20:46:57 UTC
Auto-assigned to maintainer gleb@FreeBSD.org
Comment 2 Sean Bruno freebsd_committer freebsd_triage 2015-02-04 21:04:14 UTC
Probably, instead of removing the ONLY_FOR_ARCHS, we will add armv6 for testing.

Does the kmod load and do the right things for you?
Comment 3 Vinícius Zavam freebsd_committer freebsd_triage 2015-02-05 12:40:26 UTC
(In reply to Sean Bruno from comment #2)

sure! removing 'ONLY_FOR_ARCHS' was done in a moment of laziness and as a quick test here. totally agree with you.

regarding the kmod thing, I'll touch one "native armv6 hardware" (raspberry-pi) for testing it ASAP.
Comment 4 Vinícius Zavam freebsd_committer freebsd_triage 2015-02-06 13:21:25 UTC
root@raspberry-pi:~ # uname -a
FreeBSD raspberry-pi 11.0-CURRENT FreeBSD 11.0-CURRENT #0 r278079: Mon Feb  2 20:47:38 BRT 2015     root@charlie:/panzer/charlie/crochet-freebsd/work/obj/arm.armv6/panzer/freebsd/base/sys/RPI-B  arm

root@raspberry-pi:~ # pkg install pefs-kmod
Updating Charlie repository catalogue...
Charlie repository is up-to-date.
All repositories are up-to-date.
The following 1 packages will be affected (of 0 checked):

New packages to be INSTALLED:
        pefs-kmod: 2014.03.31

The process will require 189 KiB more space.
66 KiB to be downloaded.

Proceed with this action? [y/N]: y
Fetching pefs-kmod-2014.03.31.txz: 100%   66 KiB  67.8kB/s    00:01    
Checking integrity... done (0 conflicting)
[1/1] Installing pefs-kmod-2014.03.31...
[1/1] Extracting pefs-kmod-2014.03.31: 100%
root@raspberry-pi:~ # rehash 
root@raspberry-pi:~ # kldload pefs
root@raspberry-pi:~ # kldstat 
Id Refs Address    Size     Name
 1    7 0xc0100000 695e18   kernel
 2    1 0xc2c67000 18000    pefs.ko
 3    1 0xc2c7f000 2c000    crypto.ko
 4    1 0xc2cab000 13000    zlib.ko
root@raspberry-pi:~ # mkdir ~/encrypted ~/unencrypted
root@raspberry-pi:~ # pefs addchain -f -Z ~/encrypted
Enter parent key passphrase:
Reenter parent key passphrase:
root@raspberry-pi:~ # pefs mount ~/encrypted ~/unencrypted
root@raspberry-pi:~ # pefs addkey -c ~/unencrypted
Enter passphrase:
root@raspberry-pi:~ # echo "FreeBSD" > ~/unencrypted/t.txt
root@raspberry-pi:~ # ls ~/unencrypted
.pefs.db        t.txt
root@raspberry-pi:~ # cat ~/unencrypted/t.txt 
FreeBSD
root@raspberry-pi:~ # ls ~/encrypted
.pefs.db                                .sN036DTh0AcdYbmMp35B_3sOXjKhXWoY
root@raspberry-pi:~ # cat ~/encrypted/.sN036DTh0AcdYbmMp35B_3sOXjKhXWoY 
�u�YǷb�


...
Comment 5 Sean Bruno freebsd_committer freebsd_triage 2015-02-06 17:38:05 UTC
Gleb:

Any objections to enabling this port for ARM?
Comment 6 Gleb Kurtsou freebsd_committer freebsd_triage 2015-02-07 23:14:33 UTC
(In reply to Sean Bruno from comment #5)

On objections. I can't recall any reason for not enabling pefs on other platforms other than lack of any testing.

I'm still not confident about enabling it for big endian arm. There is nothing I'm aware of that should prevent it from working, but I'd prefer to know that it first. Page size other than 4096 may be an issue in pefs.

Sean, do you have ports commit bit? I'd appreciate if you could commit the fix.
Comment 7 Sean Bruno freebsd_committer freebsd_triage 2015-02-07 23:25:48 UTC
(In reply to Gleb Kurtsou from comment #6)
Yeah, I'll add armv6 to ONLY_FOR_ARCHS.  Thanks.
Comment 8 commit-hook freebsd_committer freebsd_triage 2015-02-07 23:47:49 UTC
A commit references this bug:

Author: sbruno
Date: Sat Feb  7 23:46:57 UTC 2015
New revision: 378626
URL: https://svnweb.freebsd.org/changeset/ports/378626

Log:
  Add armv6 to supported ONLY_FOR_ARCHS list.

  PR:		197332
  Submitted by:	egypcio@googlemail.com
  Reviewed by:	gleb (maintainer)
  Approved by:	mentor (implicit)

Changes:
  head/sysutils/pefs-kmod/Makefile