Bug 197352 - [PATCH] editors/sublime3: Fix desktop file
Summary: [PATCH] editors/sublime3: Fix desktop file
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-05 16:22 UTC by Carlos J Puga Medina
Modified: 2015-02-08 23:39 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (miguelmclara)


Attachments
sublime3.diff (748 bytes, patch)
2015-02-05 16:23 UTC, Carlos J Puga Medina
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos J Puga Medina 2015-02-05 16:22:21 UTC

    
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2015-02-05 16:22:21 UTC
Maintainer CC'd
Comment 2 Carlos J Puga Medina 2015-02-05 16:23:32 UTC
Created attachment 152589 [details]
sublime3.diff

- Fix sublime_text.desktop file
Comment 3 Carlos J Puga Medina 2015-02-05 16:32:15 UTC
Miguel, you should also include a message to advertise users that it's necessary to add "link /tmp shm" in /etc/devfs.conf
Comment 4 miguelmclara 2015-02-06 18:19:59 UTC
Thanks Carlos, I have a PR open (On the smartphone now, but I'll post it here later) with the patch to the desktop file, and tbh I though It was added already.
My local version does have the patch applied (I removed the unity parts though)

In the same PR I also asked about how to deal with the shm 'issue' cause when you install linux-c6 you'll already warned about it, but the problem is that when running "sublime" with no arguments, it will simply crash with no warning about shm... with "-w" you do get warned though.. s

Since this happens I think that it might be best to check if this is set and warn users when its not... (something like what its done when you run chrome and 'kern.ipc.shm_allow_removed')
Comment 5 miguelmclara 2015-02-06 18:35:55 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=194669

That is the one!

I've re-open and asked about it (probably a new PR will have to be create) 


also note that not only sublime3 is "beta" but its also very experimental in FreeBSD, some syscalls are needed for it to fully work, I've also run into several issues with Package_Control.

There was an issue with the CAs paths, but that was fixed in git, and I think Its already fixed in the latest release.

However I've come with a python issue (shutil) and the use of the "move" function in Python3x/FreeBSD, and the best way to fix that is in Python it self, and then Sublime would need to ship a version of python with this fixed too... tbh I'm not sure if that will ever happen!

If interested see: https://github.com/wbond/package_control/pull/759

I've also experienced random crashes probably related with some syscalls missing.

The dev support for sublime3 is very slow this days (its only the one dev, and It seems their more interested in moving on to v4)
I've also mailed the dev about the shutil issue and an alternative to inotify... but got no reply so far!
Comment 6 Carlos J Puga Medina 2015-02-06 20:09:59 UTC
Basically sublime3 works for me. No crashes at the moment. Regarding to add a check in sublime3/Makefile would be fine.

% test -h /dev/shm
% echo $?
0

% ll /dev/shm
lrwxr-xr-x  1 root  wheel  4  6 feb 14:46 /dev/shm@ -> /tmp
Comment 7 miguelmclara 2015-02-07 00:37:31 UTC
I've opened a new PR for a port update (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197381)

So as soon as that gets to the ports three this will be fixed.

thanks for the report
Comment 8 Carlos J Puga Medina 2015-02-08 23:39:13 UTC
(In reply to miguelmclara from comment #7)

It was committed!