Bug 197581 - devel/psptoolchain-binutils creates directories for arm not armv6
Summary: devel/psptoolchain-binutils creates directories for arm not armv6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL: http://chips.ysv.freebsd.org/data/11a...
Keywords: needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2015-02-12 20:07 UTC by Sean Bruno
Modified: 2015-02-20 17:00 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (tphilipp)

Attachments
fix for armv6 (752 bytes, patch)
2015-02-17 15:28 UTC, Mikael Urankar 		no flags Details | Diff
Updated patch (1.07 KB, patch)
2015-02-18 17:37 UTC, Tassilo Philipp 		tphilipp: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sean Bruno freebsd_committer freebsd_triage 2015-02-12 20:07:48 UTC 
This port fails at pkg creation time as it compiles and builds an arm-unknown-freebsd directory not an armv6-unknown-freebsd.

I suspect the configure script needs to be tweaked to change this.

Probably look at devel/binutils for a clue here.

https://svnweb.freebsd.org/ports/head/devel/binutils/Makefile?revision=378882&view=markup
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2015-02-12 20:07:48 UTC 
Maintainer CC'd
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2015-02-13 02:12:04 UTC 
[tags] in summary not needed when Hardware field is set.
Comment 3 Mikael Urankar freebsd_committer freebsd_triage 2015-02-17 15:28:25 UTC 
Created attachment 153109 [details]
fix for armv6

The attached patch should fix that.

root@armv6: make -V CONFIGURE_TARGET -C /usr/ports/devel/psptoolchain-binutils
arm-unknown-freebsd11.0

root@amd64: make -V CONFIGURE_TARGET -C /usr/ports/devel/psptoolchain-binutils
x86_64-unknown-freebsd11.0

I don't have an i386 machine to test...

build log for armv6:
http://mikael.urankar.free.fr/FreeBSD/arm/build_logs/psptoolchain-binutils-2.22_1.log
Comment 4 Tassilo Philipp 2015-02-18 17:37:09 UTC 
Created attachment 153151 [details]
Updated patch

Thanks Mikael, I tested on amd64, and had to slightly tweak your patch, but it works fine. Find attached a new patch
Comment 5 Sean Bruno freebsd_committer freebsd_triage 2015-02-18 17:45:30 UTC 
(In reply to Tassilo Philipp from comment #4)
If you are ok with the patch, check the maintainer approved button on this bug and I'll commit it later today.
Comment 6 Tassilo Philipp 2015-02-18 20:19:12 UTC 
Comment on attachment 153151 [details]
Updated patch

approved
Comment 7 Sean Bruno freebsd_committer freebsd_triage 2015-02-20 16:55:11 UTC 
Comment on attachment 153109 [details]
fix for armv6

Obsoleted by maintainer.
Comment 8 commit-hook freebsd_committer freebsd_triage 2015-02-20 16:59:19 UTC 
A commit references this bug:

Author: sbruno
Date: Fri Feb 20 16:58:24 UTC 2015
New revision: 379449
URL: https://svnweb.freebsd.org/changeset/ports/379449

Log:
  Fix directory creation so that a armv6-unknown-freebsd directory is created
  instead of an arm-unkonwn-freebsd to be friendlier with freebsd pkg tools.

  PR:		197581
  Submitted by:	mikael.urankar@gmail.com
  Approved by:	tphilipp@potion-studios.com (maintainer)

Changes:
  head/devel/psptoolchain-binutils/Makefile