Bug 197583 - games/sauerbraten: convert to option helpers and dependency fixes
Summary: games/sauerbraten: convert to option helpers and dependency fixes
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-12 22:35 UTC by Jan Beich
Modified: 2015-03-15 11:56 UTC (History)
2 users (show)

See Also:


Attachments
v1 (2.07 KB, patch)
2015-02-12 22:35 UTC, Jan Beich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2015-02-12 22:35:46 UTC
Created attachment 152922 [details]
v1
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2015-02-12 22:35:46 UTC
Auto-assigned to maintainer acm@FreeBSD.org
Comment 2 Jan Beich freebsd_committer freebsd_triage 2015-02-12 22:36:09 UTC
- Convert to option helpers
- Drop implicit USE_SDL=sdl (see _REQUIRES_xxx in bsd.sdl.mk)
- Drop unused libGLU dependency (except for Cube1)
- Track direct dependency on libX11 (for XFetchBytes)
Comment 3 Jan Beich freebsd_committer freebsd_triage 2015-02-12 22:40:26 UTC
Logs and diffs for similar ports are in:
https://reviews.freebsd.org/D1831
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-03-15 11:51:48 UTC
A commit references this bug:

Author: jbeich
Date: Sun Mar 15 11:51:09 UTC 2015
New revision: 381324
URL: https://svnweb.freebsd.org/changeset/ports/381324

Log:
  Improve style, consistency and fix minor issues in Cube-based ports

  - Convert to option helpers
  - Drop unused libGLU dependency (except for games/cube)
  - Track direct dependency on libX11 (for XFetchBytes)
  - Drop redundant MKDIR before COPYTREE_* macros [1]
  - Wrap cd related commands with parentheses [1]
  - Wrap lines exceeding 80 characters
  - Bump PORTREVISION to pick up changes in dependencies, plist (assaultcube)
    and catch regressions early [1]
  - games/assaultcube: CLIENT uses openal/vorbisfile *instead* of SDL_mixer
  - games/assaultcube: drop unused gettext-tools dependency [1]
  - games/assaultcube: convert to PLIST_DIRS [1]
  - games/assaultcube: add patch for source/src/bot/bot_waypoint.cpp
    file to fix "invalid source encoding" warning [1]
  - games/{cube,bloodfrontier}: MASTER or SERVER don't need libX11
  - games/redeclipse: tell how large the package is in IGNORE message
  - games/redeclipse: use PORTDATA to hold list of dirs for COPYTREE_SHARE

  Differential Revision:	https://reviews.freebsd.org/D1831
  PR:		197582 [1]
  PR:		197583 [2]
  Submitted by:	lightside@gmx.com [1]
  Requested by:	lightside@gmx.com [1]
  Reviewed by:	amdmi3, lightside@gmx.com (maintainers)
  Approved by:	maintainer timeout (1 month) [2]
  Approved by:	bapt (mentor)

Changes:
  head/games/assaultcube/Makefile
  head/games/assaultcube/files/patch-source_src_bot_bot_waypoint.cpp
  head/games/bloodfrontier/Makefile
  head/games/cube/Makefile
  head/games/redeclipse/Makefile
  head/games/sauerbraten/Makefile