Bug 197584 - [PATCH] graphics/darktable: Add SSE2 instructions for old machines
Summary: [PATCH] graphics/darktable: Add SSE2 instructions for old machines
Status: Closed Not Accepted
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jean-Sébastien Pédron
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-12 22:43 UTC by Carlos J Puga Medina
Modified: 2015-03-11 20:20 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (dumbbell)


Attachments
patch darktable sse2 (2.51 KB, patch)
2015-02-12 22:43 UTC, Carlos J Puga Medina
no flags Details | Diff
11-i386-darktable-build.log (144.74 KB, text/x-log)
2015-02-12 22:44 UTC, Carlos J Puga Medina
no flags Details
patch darktable sse2 (2.51 KB, patch)
2015-03-10 00:14 UTC, Carlos J Puga Medina
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos J Puga Medina 2015-02-12 22:43:45 UTC
Created attachment 152923 [details]
patch darktable sse2

If I start darktable via command line it returns this error:

"Unfortunately we depend on SSE3 instructions at this time."
"Please contribute a backport patch (or buy a newer processor).

This patch will allow you to continue using darktable with SSE2 instructions.

% portlint -ac
WARN: Makefile: no ftp/http mirror in MASTER_SITES for users behind a proxy.
WARN: Consider to set DEVELOPER=yes in /etc/make.conf
0 fatal errors and 2 warnings found.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2015-02-12 22:43:45 UTC
Auto-assigned to maintainer dumbbell@FreeBSD.org
Comment 2 Carlos J Puga Medina 2015-02-12 22:44:28 UTC
Created attachment 152924 [details]
11-i386-darktable-build.log
Comment 3 Carlos J Puga Medina 2015-03-10 00:14:47 UTC
Created attachment 154118 [details]
patch darktable sse2

Regenerate patch after last port update.
Comment 4 Jean-Sébastien Pédron freebsd_committer freebsd_triage 2015-03-10 23:42:47 UTC
I didn't try the patch yet, but does darktable actually work with it? Were you able to make changes to images?

I suppose darktable really requires SSE3 instructions, but to be sure, I asked upstream and will keep you informed of their answer.
Comment 5 Carlos J Puga Medina 2015-03-10 23:53:41 UTC
(In reply to Jean-Sebastien Pedron from comment #4)

Yes, it works! Note that I've a i386 machine.

% uname -a
FreeBSD box.underbuild.com 11.0-CURRENT FreeBSD 11.0-CURRENT #0 r278756M: Sun Feb 15 06:36:30 CET 2015     charly@box.underbuild.com:/usr/obj/usr/src/sys/PROD  i386
Comment 6 Jean-Sébastien Pédron freebsd_committer freebsd_triage 2015-03-11 20:20:17 UTC
After talking with darktable developers, I'm going to refuse your patch.

SSE3 instructions are actually required by some operations since recently. So, you may be lucky and you didn't use those operations yet. But as soon as you do it, darktable will crash.

I know it is inconvenient to maintain a local patch, I'm sorry, but the package should be stable and work as upstream designed it out-of-the-box.