Bug 197609 - security/cryptlib: builds on ARMv6 (Poudriere Powered)
Summary: security/cryptlib: builds on ARMv6 (Poudriere Powered)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm Any
: --- Affects Many People
Assignee: Alex Dupre
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-14 03:34 UTC by Vinícius Zavam
Modified: 2015-02-19 11:34 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (ale)

Attachments
cryptlib-3.4.1.log (500.72 KB, text/x-log)
2015-02-14 03:34 UTC, Vinícius Zavam 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vinícius Zavam freebsd_committer freebsd_triage 2015-02-14 03:34:48 UTC 
Created attachment 152954 [details]
cryptlib-3.4.1.log

--- Makefile.orig
+++ Makefile
@@ -10,7 +10,7 @@ DISTNAME=             cl${PORTVERSION:S/.//g}
 MAINTAINER=            ale@FreeBSD.org
 COMMENT=               Powerful security programming toolkit
 
-ONLY_FOR_ARCHS=                i386 amd64
+ONLY_FOR_ARCHS=                i386 amd64 armv6
 
 OPTIONS_DEFINE=                DOCS
 
--- /dev/null
+++ files/patch-misc_os__spec.h
@@ -0,0 +1,13 @@
+--- misc/os_spec.h.orig        2015-02-13 18:19:47 UTC
++++ misc/os_spec.h
+@@ -606,9 +606,7 @@ typedef unsigned char              BYTE;
+    support for the change was added in gcc 4.4, so any newer version with 
+    ARM_EABI defined will have a scalar va_list */
+ 
+-#if defined( __GNUC__ ) && \
+-      ( ( __GNUC__ == 4 && __GNUC_MINOR__ >= 4 ) || ( __GNUC__ > 4 ) ) && \
+-      defined( __ARM_EABI__ )
++#if defined( __ARM_EABI__ )
+       /* In theory we could check __ap but in practice it's too risky to rely 
+          on the type and state of hidden internal fields, and in any case it's 
+          only a sanity check, not a hard requirement, so we just no-op the
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2015-02-14 03:34:48 UTC 
Auto-assigned to maintainer ale@FreeBSD.org
Comment 2 Vinícius Zavam freebsd_committer freebsd_triage 2015-02-14 03:38:54 UTC 
Patched by miki (#bsdmips@EFnet).
Comment 3 Mikael Urankar freebsd_committer freebsd_triage 2015-02-18 18:09:42 UTC 
Can you attach a patch that:
 - merge files/patch-misc_os__spec.h and files/patch-misc_os_spec.h into files/patch-misc_os__spec.h
 - remove files/patch-misc_os_spec.h

Thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-02-19 11:34:19 UTC 
A commit references this bug:

Author: ale
Date: Thu Feb 19 11:34:06 UTC 2015
New revision: 379340
URL: https://svnweb.freebsd.org/changeset/ports/379340

Log:
  Add armv6 as supported arch.

  PR:		197609
  Submitted by:	egypcio@googlemail.com

Changes:
  head/security/cryptlib/Makefile
  head/security/cryptlib/files/patch-misc_os_spec.h