Bug 197749 - [patch] graphics/exiv2 : not jobs safe, patch fixes it
Summary: [patch] graphics/exiv2 : not jobs safe, patch fixes it
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-multimedia (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-02-16 21:53 UTC by John Marino
Modified: 2015-03-11 18:38 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (multimedia)

Attachments
fix jobs unsafe bug (732 bytes, patch)
2015-02-16 21:53 UTC, John Marino 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Marino freebsd_committer freebsd_triage 2015-02-16 21:53:43 UTC 
Created attachment 153089 [details]
fix jobs unsafe bug

I got this failure compiling exiv2 on multijob:

c++ -pipe -O2 -fno-strict-aliasing -D_GLIBCXX_USE_CXX11_ABI=0 -fvisibility=hidden -fvisibility-inlines-hidden -Wall -Wcast-align -Wpointer-arith -Wformat-security -Wmissing-format-attribute -Woverloaded-virtual -W -MMD -I. -I/usr/local/include -DEXV_LOCALEDIR=\"/usr/local/share/locale\" -I../xmpsdk/include -c -o utils.o utils.cpp
utils.cpp:36:23: fatal error: exv_conf.h: No such file or directory

It turns out that the makefile did not have utils.cpp depending on exv_conf.h, so they built at the same time.  That attached patch should fix this.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2015-02-16 21:53:43 UTC 
Auto-assigned to maintainer multimedia@FreeBSD.org
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-03-11 18:37:07 UTC 
A commit references this bug:

Author: marino
Date: Wed Mar 11 18:37:05 UTC 2015
New revision: 381027
URL: https://svnweb.freebsd.org/changeset/ports/381027

Log:
  graphics/exiv2: Not jobs safe, so make it jobs safe

  A dependency on a header was not listed in the vendor makefile, so it
  is possible that exiv2 breaks on multi-job building.  This fixes at least
  that specific problem.

  PR:		197749
  Submitted by:	marino
  approved by:	maintainer timeout

Changes:
  head/graphics/exiv2/files/patch-src-Makefile