Bug 197869 - Fix lang/v8 build with clang 3.6.0
Summary: Fix lang/v8 build with clang 3.6.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks: 197395
  Show dependency tree / graph
 
Reported: 2015-02-20 23:04 UTC by Dimitry Andric
Modified: 2015-02-21 11:39 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (sunpoet)

Attachments
Mark temporary typedefs in static asserts as unused (1.12 KB, patch)
2015-02-20 23:04 UTC, Dimitry Andric 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitry Andric freebsd_committer freebsd_triage 2015-02-20 23:04:06 UTC 
Created attachment 153254 [details]
Mark temporary typedefs in static asserts as unused

During the exp-run in bug 197395, it was found that lang/v8 gives errors with clang 3.6.0:

http://package18.nyi.freebsd.org/data/headamd64PR197395-default/2015-02-11_23h04m51s/logs/errors/v8-3.18.5.log

This is because v8 is compiled with -Werror, and its hand-rolled implementation of static_assert uses temporary local typedefs.

To fix it, we can use the same approach as used in base, here:
https://svnweb.freebsd.org/base?view=revision&revision=278222
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2015-02-20 23:04:06 UTC 
Auto-assigned to maintainer sunpoet@FreeBSD.org
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2015-02-21 11:39:14 UTC 
It should be fixed in r379501 (tested with lang/clang36). Thanks!