Bug 198141 - Fix devel/pecl-ev build with clang 3.6.0
Summary: Fix devel/pecl-ev build with clang 3.6.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Bartek Rutkowski
URL:
Keywords:
Depends on:
Blocks: 197395
  Show dependency tree / graph
 
Reported: 2015-03-01 21:47 UTC by Dimitry Andric
Modified: 2015-03-17 19:33 UTC (History)
2 users (show)

See Also:
robak: maintainer-feedback+

Attachments
Fix positioning of _Noreturn attribute for libev (1.24 KB, patch)
2015-03-01 21:47 UTC, Dimitry Andric 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitry Andric freebsd_committer freebsd_triage 2015-03-01 21:47:12 UTC 
Created attachment 153650 [details]
Fix positioning of _Noreturn attribute for libev

During the exp-run in bug 197395, it was found that devel/pecl-ev gives errors with clang 3.6.0:

http://package18.nyi.freebsd.org/data/headamd64PR197395-default/2015-02-27_12h37m16s/logs/errors/pecl-ev-0.2.13.log

This is because the embedded copy of libev places the _Noreturn attribute in an incorrect position.  It can be fixed by the attached patch.

See also bug 197864 (for devel/libev).
Comment 1 johnpupu 2015-03-02 03:40:09 UTC 
Hi Dimitry,

Thanks for your patch.
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-03-17 19:32:56 UTC 
A commit references this bug:

Author: robak
Date: Tue Mar 17 19:32:36 UTC 2015
New revision: 381515
URL: https://svnweb.freebsd.org/changeset/ports/381515

Log:
  devel/pecl-ev: fix clang 3.6 build

  PR:		198141
  Submitted by:	Dimitry Andric <dim@FreeBSD.org>
  Approved by:	maintainer

Changes:
  head/devel/pecl-ev/files/
  head/devel/pecl-ev/files/patch-libev__ev.c
Comment 3 Bartek Rutkowski freebsd_committer freebsd_triage 2015-03-17 19:33:24 UTC 
Committed, thanks for your work!