Bug 198262 - net/samba36: add timeout option
Summary: net/samba36: add timeout option
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: VK
URL:
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2015-03-03 23:18 UTC by Mikhail T.
Modified: 2016-10-17 23:47 UTC (History)
1 user (show)

See Also:
koobs: maintainer-feedback? (timur)


Attachments
Add timeout option, stop extracting source4/ (2.13 KB, patch)
2015-03-03 23:18 UTC, Mikhail T.
koobs: maintainer-approval? (timur)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail T. 2015-03-03 23:18:40 UTC
Created attachment 153752 [details]
Add timeout option, stop extracting source4/

When smbclient is invoked to perform a long-running write -- such as when uploading a backup to an SMB-share -- it may time out, when the writer is not "fast enough".

A patch, allowing to specify a higher timeout on command-line was published years ago. The port should contain it.

The attached patch also changes the port's Makefile to avoid extracting the source4/ subtree.
Comment 1 Timur I. Bakeyev freebsd_committer freebsd_triage 2015-03-10 23:25:41 UTC
(In reply to Mikhail T. from comment #0)

I'll add timeout patch to the local(FreeBSD) ports, but I'd advice(or even insist:)) to submit this putch to the upstream. Taking into account that 3.6 is EOL, it ould be better to make such a patch against 4.*.

As for the extraction - I don't see much of the point in saving couple of seconds on extraction time, while it still could be that there are (hidden) references to the source4/ from the source3/.

With best regards,
Timur Bakeyev.
Comment 2 Mikhail T. 2015-03-10 23:55:19 UTC
(In reply to Timur I. Bakeyev from comment #1)
> insist:)) to submit this patch to the upstream

When I had the problem it is solving, I found it on Samba's mailing list -- it was submitted there in 2009:

 http://lists.samba.org/archive/samba-technical/2009-January/062964.html

I doubt, Samba folks will add it now -- especially if they consider Samba-3.x EOL. Maybe, Samba-4.x allows to specify the timeout somehow else.
Comment 3 VK freebsd_triage 2016-10-17 23:47:46 UTC
Closing, as net/samba36 expired and is removed from the tree:

https://svnweb.freebsd.org/ports?view=revision&revision=415323

Please reopen if you think this was a mistake.