Created attachment 153861 [details] svn diff for graphics/openimageio During a build with LibreSSL we've discovered a bug with graphics/openimageio. The port does not define a dependency on OpenSSL. Linking CXX executable ../../bin/blender /usr/bin/c++ ... <snip> /usr/local/lib/libXxf86vm.so -lutil -lc -lm -Wl,-rpath,/usr/local/lib: /usr/bin/ld: warning: libssl.so.30, needed by /usr/local/lib/libOpenImageIO.so, not found (try using -rpath or -rpath-link) /usr/bin/ld: warning: libcrypto.so.30, needed by /usr/local/lib/libOpenImageIO.so, not found (try using -rpath or -rpath-link) /usr/local/lib/libOpenImageIO.so: undefined reference to `SHA1_Init' Attached patch fixes this by adding OPENSSL_USE= yes
Created attachment 153876 [details] Poudriere build log of graphics/openimageio
Created attachment 153877 [details] Poudriere build log of graphics/blender Added the blender log as well as this is where the missing OpenSSL dependency resulted in a linker error. 6MB log, so zipped
Created attachment 153935 [details] disable use of openssl I had overlooked the openssl dependacy. openimageio uses the sha1 functions from openssl, if openssl isn't present it uses an internal version of sha1. The response from the lead oiio developer is that in older versions openssl offered a performance gain of about 25%. Testing now that the code that uses sha1 has been multi-threaded to use available cores makes the speed difference minimal, with disk io now being the bottleneck. He now feels that disabling the use of openssl by default is a valid option for future releases. I opt to go the same route and disable use of openssl. I think if oiio were to keep using openssl I would prefer to have it as an option rather than a permanent feature.
Hi, Let met test that tomorrow, I'll let you know. No objections to not building with OpenSSL, just want to verify that the build with LibreSSL is successful with OpenSSL disabled. Thanks! Bernard.
Looks good! The error appeared when linking Blender, hope this fixes that failure... Thanks!
Is there anything left to do before getting it into the tree? And is attachement 153935 the only one to commit?
Comment on attachment 153935 [details] disable use of openssl Maintainer, please set the maintainer-approval flag on attachment 153861 [details] and attachment 153935 [details] to + (approved) or - (not approved) according to what you would like committed. Alternatively, provide a new patch, set maintainer-approval to + on it, and obsolete others. Bernard, in future please leave flags for maintainers to modify themselves, as it allows us to record explicit proof of approval and feedback
Comment on attachment 153861 [details] svn diff for graphics/openimageio prefer to remove dependency
Comment on attachment 153935 [details] disable use of openssl Disabling openssl dependency to match changes made upstream.
Comment on attachment 153861 [details] svn diff for graphics/openimageio Just to note, another alternative is making OpenSSL support an OPTION'al dependency
Hi Marcus, The addition of USE_OPENSSL= yes is the only change. Thanks, Bernard.
Superseded by bug 200818.