Created attachment 153939 [details]
The OpenSMTPD port always modifies /etc/mail/mailer.conf. This makes installing it a destructive event---you cannot install it and tweak the configuration before making it live. To me this is a POLA violation, as other mail servers don't do that.
The attached patch adds a new OPTION, and defaults it to on, to determine whether mailer.conf is written on installation. The end result is the same for binary package users.
Also, the attached patch suggests a new COMMENT line... the current COMMENT line doesn't really say much and it violates rule #2 from https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-comment.html
A commit references this bug:
Date: Sun Mar 29 05:17:46 UTC 2015
New revision: 382567
- Add OPTION to only update mailer.conf(5) on demand
- Update COMMENT so it complies with guidelines in Porter's
Submitted by: adamw
Committed with minor changes.