(In reply to Tyler Duzan from comment #0)
> Port Name: x11/terminator
> Version: 0.97
> 
> In the port x11/terminator, after meeting all dependency requirements it
> starts the step where ./configure gets run, at which point it fails with the
> following error:
> 
> Traceback (most recent call last):
>   File "<string>", line 1, in <module>
> IOError:  [Errno 2] No such file or directory: '--without-gettext'
> *** Error code 1
> 
> Stop.
> make[1]: stopped in /usr/ports/x11/terminator
> *** Error code 1
> 
> Stop.
> make: stopped in /usr/ports/x11/terminator
> 
> Since terminator is a Python application and uses the setup.py method, I'm
> not really sure where to see to debug the resulting ./configure script that
> gets created.  In the TerminatorDist() class within setup.py is where
> global_options dict gets set to contain the tuple ("without-gettext", None,
> "Don't build/install gettext .mo files"), which I believe is where the line
> '--without-gettext' originates.
> 
> Unfortunately I don't have any more information than this to provide,
> however it is possible to reproduce this always.  During make config, I
> choose the values which represent WITHOUT_NLS and WITH_GCONF.

I'm not sure this port is still being [actively] maintained. For
example; the WWW listed in pkg-descr is obsolete. If no one else
steps up. I can take it.
BTW it would be helpful if you could mention which python version
you are using.

--Chris

Thanks for your response Chris.  I'm unsure if this port is still being actively maintained, but the software project is still under way.  The last update to their code repository was on the 5th of March, 2015, just 2 days ago.  The new website is at http://gnometerminator.blogspot.com/p/introduction.html and the code is hosted via Launchpad at https://launchpad.net/terminator

I have both Python 2.7.9 and Python 3.4.3 installed on my system, Python 2.7.9 is the default system Python, and is what was being used during the install of x11/terminator

(In reply to Tyler Duzan from comment #2)
> Thanks for your response Chris.  I'm unsure if this port is still being
> actively maintained, but the software project is still under way.  The last
> update to their code repository was on the 5th of March, 2015, just 2 days
> ago.  The new website is at
> http://gnometerminator.blogspot.com/p/introduction.html and the code is
> hosted via Launchpad at https://launchpad.net/terminator
Yes, I was aware of that, which is why I indicated it wasn't being
actively maintained. :-)
> 
> I have both Python 2.7.9 and Python 3.4.3 installed on my system, Python
> 2.7.9 is the default system Python, and is what was being used during the
> install of x11/terminator
Thanks for taking the time to provide that. It will be helpful
in determining the earliest version of Python this port will
support.
If no one else steps up within a week, I can have a new, and
functional port ready for submission, in about 15 minutes.

Thanks again, for taking the time to report your Python
version, Tyler.

--Chris

The port appends to $PYSETUP, to produce:

    setup.py --with-gettext {build,install}

This no longer works - it's expected to be a filename (used as one in
$PYDISTUTILS_SETUP), and it's evidently no longer set when that part of the
Makefile is executed, so it ends up just as "--without-gettext".

Will have a poke about later.  Right now it's way past my bedtime :)

Created attachment 154186 [details]
Preliminary patch for 0.97 -> 0.97_1

I've attached a preliminary patch to 0.90_1.  This should fix the build issue, and modernises the port somewhat.

I've also fixed cwd detection, so new tabs will again inherit the directory from your current term.

Build tested with and without both NLS and GCONF, and test run on my desktop VM.  Please test/critique :)

Created attachment 154187 [details]
poudriere testport with NLS/GCONF.

Created attachment 154188 [details]
poudriere testport without NLS.

Created attachment 154189 [details]
poudriere testport with no NLS/GCONF.

Created attachment 154191 [details]
Updated preliminary patch for 0.97 -> 0.97_1

Update patch to remove plist change - my personal repo was a little out of date.  No real functional difference.

I'll happily test this patch out, but it's not clear to me how I can make use of the patch directly in my ports tree.  Is there any documentation that would describe the process to me?

Thanks.

(In reply to Tyler Duzan from comment #10)

If you'd prefer you can grab my git repo: https://github.com/Freaky/ports

Otherwise from somewhere safe (home directory will do):

    mkdir x11 && cp -a /usr/ports/x11/terminator x11/ && patch </path/to/patch

Moo?

Will push to get this committed unless there are any objections.

Hey sorry, I've gotten sidetracked this week with a bunch of stuff.  I'm going to give it a shot here in about 20 minutes.

Thanks.

Patch verified, it appears to build cleanly on my system and I have a working x11/terminator runtime.

Not sure if additional sign-off is needed for the patch to land, but it's got my +1

Thanks.

Excellent, thanks.  No we just need an adult to commit it :)

Comment 16 Kurt Jaeger 2015-03-29 16:51:30 UTC

testing@work

Comment 17 commit-hook 2015-03-29 17:42:13 UTC

A commit references this bug:

Author: pi
Date: Sun Mar 29 17:41:13 UTC 2015
New revision: 382618
URL: https://svnweb.freebsd.org/changeset/ports/382618

Log:
  x11/terminator: fix build, WWW

  PR:		198382
  Submitted by:	Tyler Duzan <tristor@gmail.com>, Thomas Hurst <tom@hur.st> (maintainer)

Changes:
  head/x11/terminator/Makefile
  head/x11/terminator/pkg-descr

Comment 18 Kurt Jaeger 2015-03-29 17:43:22 UTC

build-test on 10.1a, 9.3a, 8.4i looks fine.

Committed, thanks.