Bug 198458 - [patch] editors/openoffice-4 respect WITHOUT_CUPS
Summary: [patch] editors/openoffice-4 respect WITHOUT_CUPS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Don Lewis
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-03-09 16:18 UTC by stacy
Modified: 2015-03-17 15:29 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (office)


Attachments
use CUPS option (648 bytes, patch)
2015-03-09 16:18 UTC, stacy
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description stacy 2015-03-09 16:18:51 UTC
Created attachment 154089 [details]
use CUPS option

configure fails if WITHOUT_CUPS is set.

I set WITHOUT_CUPS in my make.conf. Make configure fails because cups is not found.

Attached patch adds CUPS to the options and if WITHOUT_CUPS is set adds --disable-cups to CONFIGURE_ARGS
Comment 1 Don Lewis freebsd_committer freebsd_triage 2015-03-09 17:27:29 UTC
I noticed this yesterday from another angle when looking at the configure script.  When we use CUPS, we don't register it as a dependency.  The build only works because some other dependency installs CUPS for us.
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-03-17 15:05:35 UTC
A commit references this bug:

Author: truckman
Date: Tue Mar 17 15:04:53 UTC 2015
New revision: 381494
URL: https://svnweb.freebsd.org/changeset/ports/381494

Log:
  Unbreak editors/openoffice-4 and editors/openoffice-devel on systems
  where clang is the base compiler.  The issue was that these ports
  would only successfully build with gcc and libstdc++, so they
  specified USE_GCC=yes, but they linked to other C++ ports that were
  compiled with clang, which brought in libc++.  The conflict between
  libstdc++ and libc++ caused the application to crash whenever an
  operation that popped up a dialog box was attempted.  Thanks to
  dim@ for helping me track this down.  The fix is to patch various
  bits of the openoffice souce to allow it to be built with clang
  on systems where the C++ dependencies are also compiled with clang. [1]

  Add a CUPS option so that CUPS can be disabled [2].

  Register print/cups-client as a LIB_DEPENDS when CUPS is enabled.

  pkg-message claims that user settings are stored in
  ~/.openoffice,org4, whereas all other platforms seem to use
  ~/.openoffice.org/4 (or equivalent), and both openoffice-4 and
  openoffice-devel actually use ~/.openoffice.org-devel/4. The
  addition of -devel to the location happened with r325370.
  The / appears to have been introduced in r297259. Change the
  location match other platforms. Introduce a new variable
  ${AOOUDIR} so that the actual location and pkg-message stay in
  sync.

  Rename ${OOOTAG} to ${AOOTAG} and restore its value so that it
  can once again be substituted into pkg-message. It has not
  been set since r296269.

  Various Makefile cleanups:
    * Gather and sort USE_*

    * Simplify use of ${REINPLACE_CMD}

    * --x-includes and --x-libraries are automatically passed to configure,
      which ignores them

    * Get rid of unnecessary include of bsd.port.options.mk

  PR:		188088 [1]
  PR:		198458 [2]
  Differential Revision:	https://reviews.freebsd.org/D2055
  Reviewed by:	pfg
  Approved by:	mat (mentor)

Changes:
  head/editors/openoffice-4/Makefile
  head/editors/openoffice-4/files/patch-bridges_source_cpp__uno_gcc3__freebsd__intel_except.cxx
  head/editors/openoffice-4/files/patch-bridges_source_cpp__uno_gcc3__freebsd__intel_share.hxx
  head/editors/openoffice-4/files/patch-bridges_source_cpp__uno_gcc3__freebsd__intel_uno2cpp.cxx
  head/editors/openoffice-4/files/patch-bridges_source_cpp__uno_gcc3__freebsd__x86-64_except.cxx
  head/editors/openoffice-4/files/patch-bridges_source_cpp__uno_gcc3__freebsd__x86-64_share.hxx
  head/editors/openoffice-4/files/patch-bridges_source_cpp__uno_gcc3__freebsd__x86-64_uno2cpp.cxx
  head/editors/openoffice-4/files/patch-freebsd.mk
  head/editors/openoffice-4/files/patch-shell_source_unix_sysshell_recently__used__file__handler.cxx
  head/editors/openoffice-4/files/patch-unxfbsd.mk
  head/editors/openoffice-4/files/pkg-message.in
  head/editors/openoffice-devel/Makefile
  head/editors/openoffice-devel/files/patch-bridges_source_cpp__uno_gcc3__freebsd__intel_except.cxx
  head/editors/openoffice-devel/files/patch-bridges_source_cpp__uno_gcc3__freebsd__intel_share.hxx
  head/editors/openoffice-devel/files/patch-bridges_source_cpp__uno_gcc3__freebsd__intel_uno2cpp.cxx
  head/editors/openoffice-devel/files/patch-bridges_source_cpp__uno_gcc3__freebsd__x86-64_except.cxx
  head/editors/openoffice-devel/files/patch-bridges_source_cpp__uno_gcc3__freebsd__x86-64_share.hxx
  head/editors/openoffice-devel/files/patch-bridges_source_cpp__uno_gcc3__freebsd__x86-64_uno2cpp.cxx
  head/editors/openoffice-devel/files/patch-freebsd.mk
  head/editors/openoffice-devel/files/patch-shell_source_unix_sysshell_recently__used__file__handler.cxx
  head/editors/openoffice-devel/files/patch-unxfbsd.mk
  head/editors/openoffice-devel/files/pkg-message.in
Comment 3 Don Lewis freebsd_committer freebsd_triage 2015-03-17 15:29:21 UTC
CUPS option added.

The proper way to disable CUPS globally in make.conf is by adding
OPTIONS_UNSET=CUPS rather than using WITHOUT_CUPS.