Created attachment 154138 [details] The archive contains patches for 2 ports: net/remmina and net/remmina-plugins Hi! I upgraded remmina ports to the latest stable version 1.1.2. Also I changed the default gnome environment that the ports are compiled for from 2 to 3. Ports changed: net/remmina net/remmina-plugins Files added/removed for net/remmina: > svn add files/patch-remmina-plugins_CMakeLists.txt.diff > svn add files/patch-remmina-plugins_vnc_CMakeLists.txt.diff > svn add files/patch-remmina_CMakeLists.txt.diff No files were added or removed for net/remmina-plugins. These ports are dependant so I put them into one report. Please, see attached archive with patches. Best regards, Maxim Vetrov
Hi, I forgot to mention in the original post that I also removed old patch from net/remmina: > svn delete files/patch-FreeRDP-Remmina-b6a55ae Regards, Maxim
Hi,
Can you provide these diff set? E.g. as if ports was a svn repo and you did "cd net && svn diff --patch-compatible remmina remmina-plugin" I can't read this archive (downloaded to windows lap) for some reason. Also, note net/remmina was touched by yesterday, so patch should take that into account.
Ports should be updated to 1.2 version, which is 1.2.0-rcgit5 now, because we already have freerdp 1.2 in ports tree. I'll try to do it. Thanks to muxas@!
Turns out, things are more complicated than I thought. The latest "release" of freerdp project is already in our ports tree. It's marked with 1.2.0-beta1+android9 tag on Sep 12, 2014 https://github.com/FreeRDP/FreeRDP/tags Of course, they didn't stop development. But they didn't made any tags or releases since then. Meanwhile, the latest remmina tag is 1.2.0-rcgit.5. https://github.com/FreeRDP/Remmina/tags And it doesn't build against our freerdp version. No way. I tried to build all of the remmina rcgit.# and managed to build only v1.2.0-rcgit.1 tag with one additional patch. I've been using remmina a bit and found one problem with rdp plugin. It doesn't work well with 'Negotiate' auth. But freerdp from cmd works well with it. So, I beleive, this bug is already fixed somewhere in remmina code, but it needs a lot of time to dig git/bugs/pull_requests to find actual commit. Maybe someone will find it in the future. Or they rather release freerdp and remmina 1.2.0 versions. I make remmina-plugins-rdp work at least somehow now.
remmina.patch is too big to upload it here. You can download patch here: https://yadi.sk/d/52vYGsqXm6u57
Created attachment 164012 [details] net/remmina-plugins patch
Created attachment 164013 [details] net/remmina-plugin-rdp patch
I think if we don't commit these changes (and waiting for real 1.2 release) we should extend expiration date of net/remmina-plugin-rdp. http://www.freshports.org/net/remmina-plugin-rdp
The original bug report no longer appears valid, and I'm considering this feedback timeout because it wasn't a proper diff patch and the reporter never addressed issues mentioned in Comment #3. muxas, if you want to submit an updated, valid patch, please file a new bug report. timp87, thank you for your efforts, but without a valid main remmina update patch, the update to plugins is redundant. Please consider filing a separate bug.