Bug 198575 - finance/electrum: update to 2.0.2
Summary: finance/electrum: update to 2.0.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-14 11:32 UTC by Dmitry Marakasov
Modified: 2015-04-22 22:51 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (kyuupichan)


Attachments
Patch (20.38 KB, patch)
2015-03-14 11:32 UTC, Dmitry Marakasov
no flags Details | Diff
SHAR file of the updated port (14.59 KB, text/plain)
2015-04-21 05:46 UTC, kyuupichan
no flags Details
Diff of the upgrade of port to 2.0.4 (18.49 KB, patch)
2015-04-21 05:47 UTC, kyuupichan
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer freebsd_triage 2015-03-14 11:32:25 UTC
Created attachment 154292 [details]
Patch

- Update to 2.0.2
- Add LICENSE_FILE
- Sort plist
Comment 1 Dmitry Marakasov freebsd_committer freebsd_triage 2015-03-14 11:33:02 UTC
Also unbreak, the old version doesn't work: it asks 3 times whether to create wallet, then exits.
Comment 2 kyuupichan 2015-03-14 12:51:26 UTC
I've never experienced the issue you mention.

This software, being financial and protecting the user's real money, is exceptionally sensitive compared to your average port.

Whilst I'm maintainer I will only upgrade the port after having used it myself personally for a while, and only when the bugs I experience personally have been resolved.

Thanks for your understanding.
Comment 3 kyuupichan 2015-03-14 12:54:48 UTC
(In reply to Dmitry Marakasov from comment #1)

And I continue to use 1.9.8 on two machines without issue, with the latest port.
Comment 4 kyuupichan 2015-03-14 13:01:17 UTC
(In reply to Dmitry Marakasov from comment #1)

And to supplement comment #2, I've experienced and have seen others experience a couple of minor issues with 2.0.x, so I'm waiting until I feel more comfortable.  Again, this software is not a joke, I myself use it to manage thousands of dollars of my own money, and I don't want to put others in the position of using something untrustworthy.

Thanks.
Comment 5 Dmitry Marakasov freebsd_committer freebsd_triage 2015-04-01 20:01:49 UTC
Two weeks have passed, enough for maintainer timeout. Have you tested the update enough?
Comment 6 kyuupichan 2015-04-21 05:46:29 UTC
Created attachment 155790 [details]
SHAR file of the updated port

Updates the port to 2.0.4.  As the changes are large I've submitted a shar file and a diff file.
Comment 7 kyuupichan 2015-04-21 05:47:28 UTC
Created attachment 155791 [details]
Diff of the upgrade of port to 2.0.4

As the changes are large I submitted both a SHAR and a DIFF file.
Comment 8 commit-hook freebsd_committer freebsd_triage 2015-04-22 00:26:18 UTC
A commit references this bug:

Author: amdmi3
Date: Wed Apr 22 00:25:29 UTC 2015
New revision: 384471
URL: https://svnweb.freebsd.org/changeset/ports/384471

Log:
  - Update to 2.0.4

  PR:		198575
  Submitted by:	kyuupichan@gmail.com (maintainer)

Changes:
  head/finance/electrum/Makefile
  head/finance/electrum/distinfo
  head/finance/electrum/files/patch-lib__util.py
  head/finance/electrum/files/patch-setup.py
  head/finance/electrum/pkg-plist
Comment 9 Dmitry Marakasov freebsd_committer freebsd_triage 2015-04-22 00:26:24 UTC
Committed with minor changes: files/patch-setup.py and corresponding post-patch are still required for correct installation. Fix plist and add desktop-file-utils as suggested by portlint.
Comment 10 kyuupichan 2015-04-22 03:33:47 UTC
(In reply to Dmitry Marakasov from comment #9)
Hi Dmitry, oddly I don't need the patch.  I'm on Dragonfly, and I note there is an "if FreeBSD" conditional.  Perhaps that should be removed upstream?
Comment 11 kyuupichan 2015-04-22 04:20:01 UTC
(In reply to Dmitry Marakasov from comment #9)
If you can confirm it works for you removing the FreeBSD conditional and the patch, I can get the removal of the conditional done upstream.
Comment 12 Dmitry Marakasov freebsd_committer freebsd_triage 2015-04-22 20:02:58 UTC
Without the patch, it breaks with PREFIX != LOCALBASE:

https://people.freebsd.org/~amdmi3/electrum1.log

Probably it uses LOCALBASE as PREFIX.
Comment 13 kyuupichan 2015-04-22 22:43:14 UTC
Hmm.  I will get the differences in the code between FreeBSD and Dragonfly eliminated so we're at least running the same thing.  I didn't get the errors for some reason.
Comment 14 Dmitry Marakasov freebsd_committer freebsd_triage 2015-04-22 22:51:03 UTC
(In reply to kyuupichan from comment #13)
This behavior should not be different between fbsd and df. Try

PREFIX=/tmp make stage check-plist