Created attachment 154748 [details] svn diff for net/etrace Well I had some patches to submit upstream for this, but found that upstream had EOL'd, and ABANDONED etrace over 3yrs. ago. So I'm taking over development, and maintenance, from here on out. Changes: PORTVERSION, PORTREVISION, MASTER_SITES, WWW Given this hasn't *actually* been maintained, and being as I'm the current developer. I'm taking MAINTAINER. Makes sense, no? :) svn diff, and QA session LOG, are attached. Thanks! --Chris
Created attachment 154749 [details] QA session LOG for net/etrace
Created attachment 159507 [details] etrace-1.2.patch Chris, Patch attached to resolve some issues I came across. 1. PORTREVISION bump was not needed since PORTVERSION got bumped from 1.1 to 1.2. 2. Change BUILD_DEPENDS to LIB_DEPENDS. As is the original patch resulted in a busted install that didn't bring it's dependencies along with it. # ldd /usr/local/bin/etrace /usr/local/bin/etrace: libpcap.so.1 => not found (0) libdnet.so.1 => not found (0) libc.so.7 => /lib/libc.so.7 (0x800827000) # etrace Shared object "libpcap.so.1" not found, required by "etrace" Lastly, after the fixing the build/install issues the examples in etrace(8) don't work at run time. Can you help clear up what I may be missing? jason@Silverstone:/usr/local/poudriere/data/packages/110amd64-default/All % sudo etrace www.example.com Starting icmp/Echo trace to 93.184.216.34 etrace: ip_send() failed: Invalid argument jason@Silverstone:/usr/local/poudriere/data/packages/110amd64-default/All % sudo etrace -T 80 www.example.com Starting tcp/80 trace to 93.184.216.34 etrace: ip_send() failed: Invalid argument jason@Silverstone:/usr/local/poudriere/data/packages/110amd64-default/All % sudo etrace --udp 53 --data-file @dns 10.100.82.1 Starting udp/53 trace to 10.100.82.1 etrace: ip_send() failed: Invalid argument
(In reply to Jason Unovitch from comment #2) > Created attachment 159507 [details] > etrace-1.2.patch > > Chris, > Patch attached to resolve some issues I came across. > > 1. PORTREVISION bump was not needed since PORTVERSION got bumped from 1.1 > to 1.2. > > 2. Change BUILD_DEPENDS to LIB_DEPENDS. As is the original patch resulted > in a busted install that didn't bring it's dependencies along with it. > # ldd /usr/local/bin/etrace > /usr/local/bin/etrace: > libpcap.so.1 => not found (0) > libdnet.so.1 => not found (0) > libc.so.7 => /lib/libc.so.7 (0x800827000) > # etrace > Shared object "libpcap.so.1" not found, required by "etrace" > > > Lastly, after the fixing the build/install issues the examples in etrace(8) > don't work at run time. Can you help clear up what I may be missing? > > jason@Silverstone:/usr/local/poudriere/data/packages/110amd64-default/All % > sudo etrace www.example.com > Starting icmp/Echo trace to 93.184.216.34 > etrace: ip_send() failed: Invalid argument > jason@Silverstone:/usr/local/poudriere/data/packages/110amd64-default/All % > sudo etrace -T 80 www.example.com > Starting tcp/80 trace to 93.184.216.34 > etrace: ip_send() failed: Invalid argument > jason@Silverstone:/usr/local/poudriere/data/packages/110amd64-default/All % > sudo etrace --udp 53 --data-file @dns 10.100.82.1 > Starting udp/53 trace to 10.100.82.1 > etrace: ip_send() failed: Invalid argument Thank you very much for all your time, and attention to this, Jason. Yes. I'll look right into the issues. Thanks again! --Chris
(In reply to Chris Hutchinson from comment #3) Thank you Chris. If you can obsolete your original patch via "details", "edit details", "obsolete", that would be great. Please let me know when you figure things out so we can commit a known good update.
Comment on attachment 154748 [details] svn diff for net/etrace Obsoleted as per Jason's [recent] patch.
(In reply to Jason Unovitch from comment #4) > (In reply to Chris Hutchinson from comment #3) > Thank you Chris. If you can obsolete your original patch via "details", > "edit details", "obsolete", that would be great. Done! :) > Please let me know when > you figure things out so we can commit a known good update. Will do. I'll be working on it tomorrow. Thanks again, Jason! --Chris
(In reply to Jason Unovitch from comment #2) > Created attachment 159507 [details] > etrace-1.2.patch > > Chris, > Patch attached to resolve some issues I came across. > > 1. PORTREVISION bump was not needed since PORTVERSION got bumped from 1.1 > to 1.2. > > 2. Change BUILD_DEPENDS to LIB_DEPENDS. As is the original patch resulted > in a busted install that didn't bring it's dependencies along with it. > # ldd /usr/local/bin/etrace > /usr/local/bin/etrace: > libpcap.so.1 => not found (0) > libdnet.so.1 => not found (0) > libc.so.7 => /lib/libc.so.7 (0x800827000) > # etrace > Shared object "libpcap.so.1" not found, required by "etrace" > > > Lastly, after the fixing the build/install issues the examples in etrace(8) > don't work at run time. Can you help clear up what I may be missing? > > jason@Silverstone:/usr/local/poudriere/data/packages/110amd64-default/All % > sudo etrace www.example.com > Starting icmp/Echo trace to 93.184.216.34 > etrace: ip_send() failed: Invalid argument > jason@Silverstone:/usr/local/poudriere/data/packages/110amd64-default/All % > sudo etrace -T 80 www.example.com > Starting tcp/80 trace to 93.184.216.34 > etrace: ip_send() failed: Invalid argument > jason@Silverstone:/usr/local/poudriere/data/packages/110amd64-default/All % > sudo etrace --udp 53 --data-file @dns 10.100.82.1 > Starting udp/53 trace to 10.100.82.1 > etrace: ip_send() failed: Invalid argument Closer examination of your patch reveals that the patch isn't against my proposed version of etrace (1.2). You are still modifying Makefile.in with files/patch-Makefile.in. files/patch-Makefile.in no longer exists in the diff I provided with this PR(1). Because it is no longer needed. Would you be so kind as to obsolete your diff, Jason? Thanks! --Chris
(In reply to Chris Hutchinson from comment #7) > (In reply to Jason Unovitch from comment #2) > > Created attachment 159507 [details] > > etrace-1.2.patch > > ... > > Closer examination of your patch reveals that the patch isn't against > my proposed version of etrace (1.2). > You are still modifying Makefile.in with files/patch-Makefile.in. > files/patch-Makefile.in no longer exists in the diff I provided > with this PR(1). Because it is no longer needed. > > Would you be so kind as to obsolete your diff, Jason? > > Thanks! > > --Chris Please ignore. I was (mis)reading the patch here inline. Sorry for the noise! --Chris
Hmm... checking net/bpf.h presence... yes checking for net/bpf.h... yes checking for net/if.h... (cached) yes checking net/if_var.h usability... no checking net/if_var.h presence... yes configure: WARNING: net/if_var.h: present but cannot be compiled configure: WARNING: net/if_var.h: check for missing prerequisite headers? configure: WARNING: net/if_var.h: see the Autoconf documentation configure: WARNING: net/if_var.h: section "Present But Cannot Be Compiled" configure: WARNING: net/if_var.h: proceeding with the preprocessor's result configure: WARNING: net/if_var.h: in the future, the compiler will take precedence configure: WARNING: ## ------------------------------------------ ## configure: WARNING: ## Report this to the AC_PACKAGE_NAME lists. ## configure: WARNING: ## ------------------------------------------ ## checking for net/if_var.h... yes checking net/if_arp.h usability... no checking net/if_arp.h presence... yes configure: WARNING: net/if_arp.h: present but cannot be compiled configure: WARNING: net/if_arp.h: check for missing prerequisite headers? configure: WARNING: net/if_arp.h: see the Autoconf documentation configure: WARNING: net/if_arp.h: section "Present But Cannot Be Compiled" configure: WARNING: net/if_arp.h: proceeding with the preprocessor's result configure: WARNING: net/if_arp.h: in the future, the compiler will take precedence configure: WARNING: ## ------------------------------------------ ## configure: WARNING: ## Report this to the AC_PACKAGE_NAME lists. ## configure: WARNING: ## ------------------------------------------ ## checking for net/if_arp.h... yes checking net/if_dl.h usability... yes checking net/if_dl.h presence... yes checking for net/if_dl.h... yes checking net/pfilt.h usability... no checking net/pfilt.h presence... no checking for net/pfilt.h... no checking net/pfvar.h usability... no checking net/pfvar.h presence... yes configure: WARNING: net/pfvar.h: present but cannot be compiled configure: WARNING: net/pfvar.h: check for missing prerequisite headers? configure: WARNING: net/pfvar.h: see the Autoconf documentation configure: WARNING: net/pfvar.h: section "Present But Cannot Be Compiled" configure: WARNING: net/pfvar.h: proceeding with the preprocessor's result configure: WARNING: net/pfvar.h: in the future, the compiler will take precedence configure: WARNING: ## ------------------------------------------ ## configure: WARNING: ## Report this to the AC_PACKAGE_NAME lists. ## configure: WARNING: ## ------------------------------------------ ## checking for net/pfvar.h... yes checking net/radix.h usability... yes checking net/radix.h presence... yes checking for net/radix.h... yes checking net/raw.h usability... no checking net/raw.h presence... no checking for net/raw.h... no checking net/route.h usability... no checking net/route.h presence... yes configure: WARNING: net/route.h: present but cannot be compiled configure: WARNING: net/route.h: check for missing prerequisite headers? configure: WARNING: net/route.h: see the Autoconf documentation configure: WARNING: net/route.h: section "Present But Cannot Be Compiled" configure: WARNING: net/route.h: proceeding with the preprocessor's result configure: WARNING: net/route.h: in the future, the compiler will take precedence configure: WARNING: ## ------------------------------------------ ## configure: WARNING: ## Report this to the AC_PACKAGE_NAME lists. ## configure: WARNING: ## ------------------------------------------ ## checking for net/route.h... yes checking netinet/in_var.h usability... no checking netinet/in_var.h presence... yes configure: WARNING: netinet/in_var.h: present but cannot be compiled configure: WARNING: netinet/in_var.h: check for missing prerequisite headers? configure: WARNING: netinet/in_var.h: see the Autoconf documentation configure: WARNING: netinet/in_var.h: section "Present But Cannot Be Compiled" configure: WARNING: netinet/in_var.h: proceeding with the preprocessor's result configure: WARNING: netinet/in_var.h: in the future, the compiler will take precedence configure: WARNING: ## ------------------------------------------ ## configure: WARNING: ## Report this to the AC_PACKAGE_NAME lists. ## configure: WARNING: ## ------------------------------------------ ## checking for netinet/in_var.h... yes checking for net/if_tun.h... (cached) yes checking linux/if_tun.h usability... no checking linux/if_tun.h presence... no checking for linux/if_tun.h... no checking netinet/ip_fw.h usability... no checking netinet/ip_fw.h presence... yes configure: WARNING: netinet/ip_fw.h: present but cannot be compiled configure: WARNING: netinet/ip_fw.h: check for missing prerequisite headers? configure: WARNING: netinet/ip_fw.h: see the Autoconf documentation configure: WARNING: netinet/ip_fw.h: section "Present But Cannot Be Compiled" configure: WARNING: netinet/ip_fw.h: proceeding with the preprocessor's result configure: WARNING: netinet/ip_fw.h: in the future, the compiler will take precedence configure: WARNING: ## ------------------------------------------ ## configure: WARNING: ## Report this to the AC_PACKAGE_NAME lists. ## configure: WARNING: ## ------------------------------------------ ## checking for netinet/ip_fw.h... yes checking linux/ip_fw.h usability... no checking linux/ip_fw.h presence... no checking for linux/ip_fw.h... no checking linux/ip_fwchains.h usability... no checking linux/ip_fwchains.h presence... no checking for linux/ip_fwchains.h... no checking linux/netfilter_ipv4/ipchains_core.h usability... no checking linux/netfilter_ipv4/ipchains_core.h presence... no checking for linux/netfilter_ipv4/ipchains_core.h... no checking ip_fil_compat.h usability... no checking ip_fil_compat.h presence... no checking for ip_fil_compat.h... no checking netinet/ip_fil_compat.h usability... no checking netinet/ip_fil_compat.h presence... no checking for netinet/ip_fil_compat.h... no checking ip_compat.h usability... no checking ip_compat.h presence... no checking for ip_compat.h... no checking netinet/ip_compat.h usability... no checking netinet/ip_compat.h presence... yes configure: WARNING: netinet/ip_compat.h: present but cannot be compiled configure: WARNING: netinet/ip_compat.h: check for missing prerequisite headers? configure: WARNING: netinet/ip_compat.h: see the Autoconf documentation configure: WARNING: netinet/ip_compat.h: section "Present But Cannot Be Compiled" configure: WARNING: netinet/ip_compat.h: proceeding with the preprocessor's result configure: WARNING: netinet/ip_compat.h: in the future, the compiler will take precedence configure: WARNING: ## ------------------------------------------ ## configure: WARNING: ## Report this to the AC_PACKAGE_NAME lists. ## configure: WARNING: ## ------------------------------------------ ## checking for netinet/ip_compat.h... yes checking ip_fil.h usability... no checking ip_fil.h presence... no checking for ip_fil.h... no checking netinet/ip_fil.h usability... no checking netinet/ip_fil.h presence... yes configure: WARNING: netinet/ip_fil.h: present but cannot be compiled configure: WARNING: netinet/ip_fil.h: check for missing prerequisite headers? configure: WARNING: netinet/ip_fil.h: see the Autoconf documentation configure: WARNING: netinet/ip_fil.h: section "Present But Cannot Be Compiled" configure: WARNING: netinet/ip_fil.h: proceeding with the preprocessor's result configure: WARNING: netinet/ip_fil.h: in the future, the compiler will take precedence configure: WARNING: ## ------------------------------------------ ## configure: WARNING: ## Report this to the AC_PACKAGE_NAME lists. ## configure: WARNING: ## ------------------------------------------ ## checking for netinet/ip_fil.h... yes Something has changed since I created this port 5 months ago. At that time, these errors didn't exist. This is going to take more time than I have at the moment. I'll have to open | reopen this when I have more time to track these down. --Chris