Bug 198951 - [NEW PORT] x11-themes/evolvere-icon-theme: Icon themes for KDE, Gnome, Xfce
Summary: [NEW PORT] x11-themes/evolvere-icon-theme: Icon themes for KDE, Gnome, Xfce
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2015-03-27 16:25 UTC by Denis Akiyakov
Modified: 2016-05-30 12:17 UTC (History)
2 users (show)

See Also:
koobs: maintainer-feedback+


Attachments
shar file (6.37 KB, text/plain)
2015-03-27 16:25 UTC, Denis Akiyakov
no flags Details
shar file (6.63 KB, text/plain)
2015-03-28 03:03 UTC, Denis Akiyakov
no flags Details
shar file (6.64 KB, text/plain)
2015-03-28 05:02 UTC, Denis Akiyakov
no flags Details
shar file (6.69 KB, text/plain)
2015-03-29 05:25 UTC, Denis Akiyakov
no flags Details
shar file (6.99 KB, text/plain)
2015-04-01 02:40 UTC, Denis Akiyakov
no flags Details
shar file (10.40 KB, text/plain)
2015-04-01 13:50 UTC, Denis Akiyakov
no flags Details
shar file (10.96 KB, text/plain)
2015-04-17 02:51 UTC, Denis Akiyakov
no flags Details
shar file v8 (10.96 KB, text/plain)
2015-04-17 15:42 UTC, Denis Akiyakov
no flags Details
portlint output (4.60 KB, text/plain)
2015-04-17 15:42 UTC, Denis Akiyakov
no flags Details
poudriere testport output (15.08 KB, text/plain)
2015-04-17 15:43 UTC, Denis Akiyakov
no flags Details
shar file v9 (10.97 KB, text/plain)
2015-04-18 02:24 UTC, Denis Akiyakov
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Denis Akiyakov 2015-03-27 16:25:07 UTC
Created attachment 154869 [details]
shar file

Hello, this is my first port.

In pkg-descr says: 

A modern icons collection which contains more than 25 different
icon themes created by Frank Souza. This icons collection is
distinguished by its smoothness and shapes' squareness. Icon themes
are compatible with KDE, Gnome, Xfce, Mate, etc.

WWW: https://github.com/franksouza183/EvolvereSuit


Also, if you want to take a look on some screen shots, please, visit author page: https://plus.google.com/111079135224465849361/posts
Comment 1 Denis Akiyakov 2015-03-27 16:31:53 UTC
Forgot to say that dynamic plist creation logic was taken from x11-themes/kde-icons-noia.
Comment 2 Denis Akiyakov 2015-03-28 03:03:32 UTC
Created attachment 154899 [details]
shar file

added OPTIONS_DEFAULT
Comment 3 Denis Akiyakov 2015-03-28 05:02:38 UTC
Created attachment 154900 [details]
shar file

OPTIONS moved to a separate file
Comment 4 Denis Akiyakov 2015-03-29 05:25:12 UTC
Created attachment 154948 [details]
shar file

-source updated to more fresh commit;
-overwriting menu icon in cinnamon added;
-pkg-descr updated;
Comment 5 Denis Akiyakov 2015-04-01 02:40:26 UTC
Created attachment 155074 [details]
shar file

updated with new commit;

Added workaround to fix an issue with the wrong size of icons in GNOME and related DE's
Comment 6 Denis Akiyakov 2015-04-01 13:50:04 UTC
Created attachment 155085 [details]
shar file

Author has made a big update. He added more than 20 new variants of icon theme. So, the archive is ~ 850Mb for now.

Makefile logic has been completely redesigned. Previously we delete unwanted icon folders from the working directory, now we do not extract them from the archive. I took some idea from qt4 ports.

Also, I've updated pkg-descr.
Comment 7 Denis Akiyakov 2015-04-17 02:51:12 UTC
Created attachment 155656 [details]
shar file

*Some variables was renamed from i,j,k to significant words in Makefile
*Default enabled icon set was fixed to first set
*pkg-message was added with hint to kde4 users
Comment 8 Kubilay Kocak freebsd_committer freebsd_triage 2015-04-17 04:45:39 UTC
Thanks for your submission Denis. Can you please add appropriate QA results in the form of:

- portlint -AC output (as attachment)
- poudriere testport (or bulk -t) output (as an attachment)

This will ensure any issues with the port are resolved as early as possible, and encourage progress for your issue.
Comment 9 Denis Akiyakov 2015-04-17 15:42:18 UTC
Created attachment 155674 [details]
shar file v8

Hello, Kubilay. Thanks for your time. I've done tests you are asking for. Also, I've removed option GH_COMMIT and made some changes due to it.
Comment 10 Denis Akiyakov 2015-04-17 15:42:50 UTC
Created attachment 155675 [details]
portlint output
Comment 11 Denis Akiyakov 2015-04-17 15:43:37 UTC
Created attachment 155676 [details]
poudriere testport output
Comment 12 Denis Akiyakov 2015-04-18 02:24:17 UTC
Created attachment 155685 [details]
shar file v9

in pkg-message used '=' instead of '*'
Comment 13 Kurt Jaeger freebsd_committer freebsd_triage 2015-10-28 18:52:31 UTC
I've had a look at it. The distfile is a whopping 820 MB ? Is there a chance
to distribute it in several distfiles according to the sets selected by the
user ?
Comment 14 Denis Akiyakov 2015-10-28 20:24:37 UTC
Hello. Thank you for response. That is true, distfile is huge. There are a lot of icons:)

I tried to think in the same direction, but as I remember, there is no way to download single or several folders with ports api from github.
Comment 15 Kurt Jaeger freebsd_committer freebsd_triage 2015-10-28 21:14:03 UTC
Maybe the API can be enhanced. I'll ask around.
Comment 16 Mathieu Arnold freebsd_committer freebsd_triage 2015-10-29 07:59:16 UTC
(In reply to Kurt Jaeger from comment #15)
> Maybe the API can be enhanced. I'll ask around.

It can't, the GitHub API is pretty simple:

https://developer.github.com/v3/repos/contents/#get-archive-link

The best bet would be to manually create one archive per set using git archive, possibly compressing them with xz instead of the default gzip in the mean time.

Something like:

for i in <list of directories>
do
git archive --format tar --prefix franksouza183-EvolvereSuit-$i-902379c/ HEAD -- $i | xz -9 > franksouza183-EvolvereSuit-$i-902379c.tar.xz
done

It could even be added to the Makefile for easy update when there are new releases.
Comment 17 Mathieu Arnold freebsd_committer freebsd_triage 2015-10-29 08:05:08 UTC
Or you could add no DISTFILE, write your own do-fetch target, use the svn interface and do something like this:

do-fetch:
.for i in ${PORT_OPTIONS:MSET*}
        cd ${WRKDIR} && svn export https://github.com/franksouza183/EvolvereSuit/trunk/${${i}_FOLDER} franksouza183-EvolvereSuit-${${i}_FOLDER}
.endfor

There should be a way to specify the revision you want, YMMV.
Comment 18 Denis Akiyakov 2015-10-29 10:20:18 UTC
Hello, I've checked out the second method through svn and it is works, but I can't find how to throw revision version to it. 'svnlite -r ' throws some error...

Maybe later I'll check the first method.
Comment 19 VK freebsd_triage 2016-05-30 11:17:25 UTC
Hello Denis, any updates on this?
Comment 20 Denis Akiyakov 2016-05-30 11:37:39 UTC
Hello, I'm sorry. I'm not interested in this PR anymore. If someone want help here, please, feel free.
Comment 21 VK freebsd_triage 2016-05-30 12:17:51 UTC
Denis, thanks for letting us now. Closing because new ports in general require submitters to take maintainership.

If anyone wants to submit and maintain this icon set, a new port submission is welcome.