Bug 199016 - [textproc/ibus] [PATCH] Fixed gettext dependency
Summary: [textproc/ibus] [PATCH] Fixed gettext dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-03-30 08:24 UTC by Yuri Victorovich
Modified: 2015-05-03 17:00 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (henry.hu.sh)

Attachments
patch (747 bytes, patch)
2015-03-30 08:24 UTC, Yuri Victorovich 		no flags Details | Diff
poudriere log (138.10 KB, text/plain)
2015-03-30 08:28 UTC, Yuri Victorovich 		no flags Details
patch to fix gettext and NLS (759 bytes, patch)
2015-04-11 07:13 UTC, Henry Hu 		henry.hu.sh: maintainer-approval+
Details | Diff
fix NLS (318 bytes, patch)
2015-04-13 01:25 UTC, Henry Hu 		henry.hu.sh: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2015-03-30 08:24:06 UTC 
Created attachment 154985 [details]
patch

poudriere build currently fails when NLS=off due to unsatisfied gettext dependency.
Attaching new, successful poudriere log (with this patch).
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2015-03-30 08:28:31 UTC 
Created attachment 154986 [details]
poudriere log
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2015-03-30 08:30:09 UTC 
Please also fix this warning from configure:
> configure: WARNING: unrecognized options: --without-nls
- see it in poudriere log
Comment 3 Henry Hu 2015-04-11 07:13:49 UTC 
Created attachment 155450 [details]
patch to fix gettext and NLS

Please try this patch.
Someone changed the Makefile to use NLS_CONFIGURE_WITH in r360404. However, he should have used NLS_CONFIGURE_ENABLE.
Even without NLS, gettext seems to be required for intltool.
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2015-04-11 07:39:44 UTC 
Yes, with this patch it builds with and without NLS option.
Comment 5 Henry Hu 2015-04-13 01:25:57 UTC 
Created attachment 155530 [details]
fix NLS

Well, someone has fixed the compilation with NLS=off.
Now just fix the configure argument. NLS_CONFIGURE_WITH should be NLS_CONFIGURE_ENABLE.
Comment 6 commit-hook freebsd_committer freebsd_triage 2015-05-03 16:58:28 UTC 
A commit references this bug:

Author: jbeich
Date: Sun May  3 16:57:34 UTC 2015
New revision: 385290
URL: https://svnweb.freebsd.org/changeset/ports/385290

Log:
  textproc/ibus: restore --disable-nls after r360404 switched to --without-nls

  PR:		199016
  Submitted by:	Henry Hu <henry.hu.sh@gmail.com> (maintainer)

Changes:
  head/textproc/ibus/Makefile
Comment 7 Jan Beich freebsd_committer freebsd_triage 2015-05-03 17:00:48 UTC 
Thanks. Committed only followup for ports r383811.